remove DeprecatedFairnessShuffler

[msmouse]

Description

Never enabled on either testnet or mainnet.

How Has This Been Tested?

compact test.

Key Areas to Review

Type of Change

• Refactoring

Which Components or Systems Does This Change Impact?

• Validator Node

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 1h 14m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	24m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	⬜
check-dynamic-deps	5m	🟩 🟩 🟩
rust-doc-tests	5m	🟩
test-target-determinator	4m	🟩
execution-performance / test-target-determinator	4m	🟩
check	4m	🟩
rust-cargo-deny	3m	🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
semgrep/ci	1m	🟩 🟩 🟩
general-lints	54s	🟩 🟩
file_change_determinator	20s	🟩 🟩
file_change_determinator	10s	🟩
permission-check	10s	🟩 🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	24m	17m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[zekun000]

if it's never enabled, you can just use DeprecatedFairness without fields?

[github-actions]

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6 (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 10774.59 txn/s, latency: 3095.48 ms, (p50: 1900 ms, p70: 2200, p90: 7300 ms, p99: 25400 ms), latency samples: 386640
2. Upgrading first Validator to new version: 9129fb12288e0dbd87d7735bba173ac56306fbf6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6382.07 txn/s, latency: 4176.11 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5300 ms), latency samples: 129580
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7016.31 txn/s, latency: 4576.57 ms, (p50: 4600 ms, p70: 4900, p90: 6800 ms, p99: 7000 ms), latency samples: 238420
3. Upgrading rest of first batch to new version: 9129fb12288e0dbd87d7735bba173ac56306fbf6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3528.41 txn/s, latency: 7743.24 ms, (p50: 9700 ms, p70: 10300, p90: 12800 ms, p99: 13200 ms), latency samples: 66320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6121.54 txn/s, latency: 5176.31 ms, (p50: 5200 ms, p70: 5500, p90: 7300 ms, p99: 7600 ms), latency samples: 208200
4. upgrading second batch to new version: 9129fb12288e0dbd87d7735bba173ac56306fbf6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9160.29 txn/s, latency: 2844.87 ms, (p50: 2600 ms, p70: 3000, p90: 5600 ms, p99: 7200 ms), latency samples: 176460
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8773.23 txn/s, latency: 2924.82 ms, (p50: 2900 ms, p70: 3100, p90: 3400 ms, p99: 4000 ms), latency samples: 361900
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 9129fb12288e0dbd87d7735bba173ac56306fbf6

two traffics test: inner traffic : committed: 13175.20 txn/s, submitted: 13176.88 txn/s, expired: 1.68 txn/s, latency: 3006.89 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 6900 ms), latency samples: 5009580
two traffics test : committed: 100.02 txn/s, latency: 1765.19 ms, (p50: 1600 ms, p70: 1600, p90: 1800 ms, p99: 6900 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.251, avg: 0.230", "QsPosToProposal: max: 1.282, avg: 1.094", "ConsensusProposalToOrdered: max: 0.324, avg: 0.312", "ConsensusOrderedToCommit: max: 0.509, avg: 0.492", "ConsensusProposalToCommit: max: 0.821, avg: 0.804"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.22s no progress at version 1545381 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.11s no progress at version 1545379 (avg 8.10s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6 (PR)
Upgrade the nodes to version: 9129fb12288e0dbd87d7735bba173ac56306fbf6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1220.08 txn/s, submitted: 1223.28 txn/s, failed submission: 3.20 txn/s, expired: 3.20 txn/s, latency: 2684.80 ms, (p50: 2400 ms, p70: 2700, p90: 4800 ms, p99: 6300 ms), latency samples: 106660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1088.48 txn/s, submitted: 1091.11 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2985.14 ms, (p50: 2400 ms, p70: 3000, p90: 5800 ms, p99: 8500 ms), latency samples: 90840
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 9129fb12288e0dbd87d7735bba173ac56306fbf6 passed
Upgrade the remaining nodes to version: 9129fb12288e0dbd87d7735bba173ac56306fbf6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1154.15 txn/s, submitted: 1157.85 txn/s, failed submission: 3.70 txn/s, expired: 3.70 txn/s, latency: 2655.97 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6500 ms), latency samples: 105960
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking