Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Small improvements to forge, consensus observer and state sync. #14825

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Oct 1, 2024

Description

This PR offers several small improvements (each in their own commit):

  1. Improve the FullNodeRebootStressTest by preventing node reboots from happening too close to the end of the test.
  2. Disable consensus observer on VFNs (by default). VFNs are still opt-in, and will be turned on once a few improvements are made.
  3. Bump the max message size for state sync (from 8MB to 10MB). This should help favour output syncing a little more.

Testing Plan

Existing test infrastructure.

Copy link

trunk-io bot commented Oct 1, 2024

@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 1, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind enabled auto-merge (rebase) October 2, 2024 02:11

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ Forge suite realistic_env_max_load success on 4137739855f1e03badf35cda361c760f7fa6b3f5

two traffics test: inner traffic : committed: 11708.30 txn/s, latency: 3398.77 ms, (p50: 3000 ms, p70: 3300, p90: 4200 ms, p99: 7200 ms), latency samples: 4451800
two traffics test : committed: 100.04 txn/s, latency: 2874.87 ms, (p50: 2600 ms, p70: 2900, p90: 3900 ms, p99: 6700 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.247, avg: 0.231", "QsPosToProposal: max: 0.452, avg: 0.366", "ConsensusProposalToOrdered: max: 0.335, avg: 0.323", "ConsensusOrderedToCommit: max: 0.575, avg: 0.530", "ConsensusProposalToCommit: max: 0.902, avg: 0.853"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.50s no progress at version 1860615 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.36s no progress at version 1860613 (avg 7.36s) [limit 15].
Test Ok

@JoshLind JoshLind disabled auto-merge October 2, 2024 18:07
@JoshLind JoshLind merged commit 37a7c8a into main Oct 2, 2024
45 of 48 checks passed
@JoshLind JoshLind deleted the forge_imp branch October 2, 2024 18:07
Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Forge suite framework_upgrade failure on 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 4137739855f1e03badf35cda361c760f7fa6b3f5

Forge test runner terminated:
Trailing Log Lines:
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  36: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  37: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  38: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  39: main
  40: __libc_start_main
  41: _start
Debugging output:
NAME                                   READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0               1/1     Running     0          18m
aptos-node-1-validator-0               1/1     Running     0          18m
aptos-node-2-validator-0               1/1     Running     0          18m
aptos-node-3-validator-0               1/1     Running     0          18m
genesis-aptos-genesis-eforge75-mdsmd   0/1     Completed   0          21m

Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Forge suite compat failure on 628e88b8a1971b4986dfb2b88ec763090f85c82f ==> 4137739855f1e03badf35cda361c760f7fa6b3f5

Forge test runner terminated:
Trailing Log Lines:
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  36: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  37: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  38: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  39: main
  40: __libc_start_main
  41: _start
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                1/1     Running     0          18m
aptos-node-1-validator-0                1/1     Running     0          18m
aptos-node-2-validator-0                1/1     Running     0          18m
aptos-node-3-validator-0                1/1     Running     0          18m
genesis-aptos-genesis-eforge238-95kpn   0/1     Completed   0          21m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants