[move-vm] Fix a bug in order of bounds checking

[wrwg]

Description

Fixed ordering of bounds checking, remove obsolete debug print.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

[trunk-io]

⏱️ 1h 30m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	23m	🟩
rust-move-tests	10m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-tests	10m	🟩
rust-move-unit-coverage	10m	🟩
rust-doc-tests	5m	🟩
test-target-determinator	4m	🟩
execution-performance / test-target-determinator	4m	🟩
check	3m	🟩
rust-cargo-deny	3m	🟩 🟩
check-dynamic-deps	3m	🟩 🟩 🟩
fetch-last-released-docker-image-tag	1m	🟩
semgrep/ci	1m	🟩 🟩 🟩
general-lints	51s	🟩 🟩
file_change_determinator	28s	🟩 ⬜ 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	23m	17m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[wrwg]

• [move-vm] Fix a bug in order of bounds checking #14821 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.8%. Comparing base (a2f756a) to head (42b12b6).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #14821     +/-   ##
=========================================
- Coverage    59.8%    59.8%   -0.1%     
=========================================
  Files         853      853             
  Lines      207922   207917      -5     
=========================================
- Hits       124351   124342      -9     
- Misses      83571    83575      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0 (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 12303.58 txn/s, latency: 2325.23 ms, (p50: 1800 ms, p70: 2000, p90: 2200 ms, p99: 26200 ms), latency samples: 501780
2. Upgrading first Validator to new version: 42b12b63e986f3122169027f1125fa08611649c0
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7646.12 txn/s, latency: 3672.18 ms, (p50: 3900 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 133900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7213.15 txn/s, latency: 4494.62 ms, (p50: 4800 ms, p70: 5000, p90: 5200 ms, p99: 5300 ms), latency samples: 240380
3. Upgrading rest of first batch to new version: 42b12b63e986f3122169027f1125fa08611649c0
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6952.79 txn/s, latency: 4060.97 ms, (p50: 4400 ms, p70: 4800, p90: 5100 ms, p99: 5200 ms), latency samples: 131340
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7089.68 txn/s, latency: 4528.81 ms, (p50: 4800 ms, p70: 5200, p90: 5900 ms, p99: 6200 ms), latency samples: 242960
4. upgrading second batch to new version: 42b12b63e986f3122169027f1125fa08611649c0
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10698.60 txn/s, latency: 2453.49 ms, (p50: 2500 ms, p70: 2800, p90: 3400 ms, p99: 5500 ms), latency samples: 191480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10683.21 txn/s, latency: 2936.18 ms, (p50: 2700 ms, p70: 3200, p90: 3700 ms, p99: 5000 ms), latency samples: 353860
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0 (PR)
Upgrade the nodes to version: 42b12b63e986f3122169027f1125fa08611649c0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1172.64 txn/s, submitted: 1175.74 txn/s, failed submission: 3.10 txn/s, expired: 3.10 txn/s, latency: 2689.68 ms, (p50: 2400 ms, p70: 2700, p90: 4600 ms, p99: 6000 ms), latency samples: 105980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1112.11 txn/s, submitted: 1115.21 txn/s, failed submission: 3.10 txn/s, expired: 3.10 txn/s, latency: 2700.69 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5900 ms), latency samples: 100500
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 42b12b63e986f3122169027f1125fa08611649c0 passed
Upgrade the remaining nodes to version: 42b12b63e986f3122169027f1125fa08611649c0
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1132.40 txn/s, submitted: 1135.55 txn/s, failed submission: 3.15 txn/s, expired: 3.15 txn/s, latency: 2712.01 ms, (p50: 2400 ms, p70: 2700, p90: 4100 ms, p99: 6600 ms), latency samples: 100540
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 42b12b63e986f3122169027f1125fa08611649c0

two traffics test: inner traffic : committed: 13145.96 txn/s, submitted: 13152.32 txn/s, expired: 6.36 txn/s, latency: 2989.76 ms, (p50: 2400 ms, p70: 3000, p90: 4800 ms, p99: 10200 ms), latency samples: 4998500
two traffics test : committed: 100.08 txn/s, latency: 3246.63 ms, (p50: 2100 ms, p70: 3400, p90: 7600 ms, p99: 10300 ms), latency samples: 1920
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.231, avg: 0.215", "QsPosToProposal: max: 0.439, avg: 0.302", "ConsensusProposalToOrdered: max: 0.310, avg: 0.297", "ConsensusOrderedToCommit: max: 0.501, avg: 0.449", "ConsensusProposalToCommit: max: 0.807, avg: 0.747"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 2065106 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.72s no progress at version 2065104 (avg 6.09s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking