Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use runs-on for fullnode-sync workflows #14782

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Sep 27, 2024

Description

Migrate the fullnode-sync workflows to use the runs-on runners. Also removed the install dependencies step since this should now be installed in the runs-on base image

How Has This Been Tested?

Ran some of the fullnode sync workflows:

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 27, 2024

⏱️ 20m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 5m 🟩🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 36s 🟩🟩🟩
check-repo 23s 🟩🟩
check-repo 14s 🟩
check-repo 13s 🟩
check-repo 13s 🟩
permission-check 13s 🟩🟩🟩
permission-check 12s 🟩🟩🟩
check-repo 12s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon requested review from geekflyer, JoshLind and a team September 30, 2024 15:18
@aluon aluon marked this pull request as ready for review September 30, 2024 15:18
@aluon aluon requested a review from a team as a code owner September 30, 2024 15:18
@aluon aluon enabled auto-merge (squash) October 9, 2024 17:46

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite realistic_env_max_load success on f5e925b24a2cea0e261159180f1fd98aee0eedf2

two traffics test: inner traffic : committed: 13582.77 txn/s, latency: 2928.38 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 8400 ms), latency samples: 5164560
two traffics test : committed: 99.97 txn/s, latency: 2592.64 ms, (p50: 2400 ms, p70: 2600, p90: 2700 ms, p99: 11700 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.241, avg: 0.220", "QsPosToProposal: max: 0.307, avg: 0.261", "ConsensusProposalToOrdered: max: 0.334, avg: 0.301", "ConsensusOrderedToCommit: max: 0.474, avg: 0.445", "ConsensusProposalToCommit: max: 0.770, avg: 0.746"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 1899911 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.30s no progress at version 1899909 (avg 7.60s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2 (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 15045.96 txn/s, latency: 2209.33 ms, (p50: 2100 ms, p70: 2200, p90: 2600 ms, p99: 6000 ms), latency samples: 504480
2. Upgrading first Validator to new version: f5e925b24a2cea0e261159180f1fd98aee0eedf2
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5986.75 txn/s, latency: 4396.56 ms, (p50: 5000 ms, p70: 5100, p90: 5400 ms, p99: 5700 ms), latency samples: 123280
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6226.89 txn/s, latency: 5161.60 ms, (p50: 5400 ms, p70: 5600, p90: 7200 ms, p99: 7600 ms), latency samples: 218780
3. Upgrading rest of first batch to new version: f5e925b24a2cea0e261159180f1fd98aee0eedf2
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7191.81 txn/s, latency: 3937.48 ms, (p50: 4400 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 131700
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6928.85 txn/s, latency: 4606.18 ms, (p50: 4700 ms, p70: 4800, p90: 6700 ms, p99: 7200 ms), latency samples: 230520
4. upgrading second batch to new version: f5e925b24a2cea0e261159180f1fd98aee0eedf2
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9240.87 txn/s, latency: 2988.20 ms, (p50: 2400 ms, p70: 2700, p90: 6000 ms, p99: 9000 ms), latency samples: 162060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11517.49 txn/s, latency: 2726.68 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3500 ms), latency samples: 374080
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2 passed
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2 (PR)
Upgrade the nodes to version: f5e925b24a2cea0e261159180f1fd98aee0eedf2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1168.88 txn/s, submitted: 1170.91 txn/s, failed submission: 2.03 txn/s, expired: 2.03 txn/s, latency: 2599.98 ms, (p50: 2400 ms, p70: 2900, p90: 4200 ms, p99: 5600 ms), latency samples: 103840
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1171.81 txn/s, submitted: 1173.83 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2602.75 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 5700 ms), latency samples: 104200
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> f5e925b24a2cea0e261159180f1fd98aee0eedf2 passed
Upgrade the remaining nodes to version: f5e925b24a2cea0e261159180f1fd98aee0eedf2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1264.89 txn/s, submitted: 1268.51 txn/s, failed submission: 3.62 txn/s, expired: 3.62 txn/s, latency: 2352.86 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5200 ms), latency samples: 111760
Test Ok

@aluon aluon merged commit 28530a7 into main Oct 9, 2024
50 checks passed
@aluon aluon deleted the aluon/runs-on-fullnode-sync branch October 9, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants