Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeless hotfix (#275) #14739

Merged
merged 2 commits into from
Sep 25, 2024
Merged

timeless hotfix (#275) #14739

merged 2 commits into from
Sep 25, 2024

Conversation

sherry-x
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 24, 2024

⏱️ 14h 44m total CI duration on this PR
Job Cumulative Duration Recent Runs
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 8h 12m 🟥
execution-performance / single-node-performance 1h 34m 🟩🟩🟥🟩🟩
forge-compat-test / forge 1h 8m 🟩🟩🟩
forge-framework-upgrade-test / forge 50m 🟩🟩🟩
forge-e2e-test / forge 42m 🟩🟩🟩
execution-performance / test-target-determinator 21m 🟩🟩🟩🟩🟩
test-target-determinator 20m 🟩🟩🟩🟩
check 17m 🟩🟩🟩🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 9m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 5m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-move-tests 3m 🟥
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 2m
rust-move-tests 2m
rust-doc-tests 2m 🟥
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 52s 🟩🟩🟩🟩🟩
file_change_determinator 36s 🟩🟩🟩
rust-move-tests 23s
determine-docker-build-metadata 17s 🟩🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 14s 🟩🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 14s 🟩🟩🟩🟩🟩 (+1 more)
Backport PR 10s 🟥🟥
permission-check 8s 🟩🟩🟩
permission-check 6s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 6h 2m +23879%
general-lints 26s 2m -75%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x enabled auto-merge (rebase) September 24, 2024 17:51

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sherry-x sherry-x requested a review from zjma September 24, 2024 21:22
@gedigi gedigi added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 25, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 74d5a4aed0ad84677b03f2440ce94180bcaa2007

two traffics test: inner traffic : committed: 14375.54 txn/s, latency: 2764.62 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5466060
two traffics test : committed: 100.04 txn/s, latency: 1637.97 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 7100 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.257, avg: 0.230", "QsPosToProposal: max: 1.108, avg: 1.080", "ConsensusProposalToOrdered: max: 0.327, avg: 0.294", "ConsensusOrderedToCommit: max: 0.414, avg: 0.404", "ConsensusProposalToCommit: max: 0.706, avg: 0.698"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 2491172 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.37s no progress at version 2491170 (avg 8.37s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007 (PR)
Upgrade the nodes to version: 74d5a4aed0ad84677b03f2440ce94180bcaa2007
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1256.37 txn/s, submitted: 1260.68 txn/s, failed submission: 4.31 txn/s, expired: 4.31 txn/s, latency: 2411.41 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5100 ms), latency samples: 110720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1349.24 txn/s, submitted: 1351.75 txn/s, failed submission: 2.50 txn/s, expired: 2.50 txn/s, latency: 2256.24 ms, (p50: 2100 ms, p70: 2400, p90: 3100 ms, p99: 4500 ms), latency samples: 118600
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007 passed
Upgrade the remaining nodes to version: 74d5a4aed0ad84677b03f2440ce94180bcaa2007
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 889.63 txn/s, submitted: 891.38 txn/s, failed submission: 1.36 txn/s, expired: 1.76 txn/s, latency: 3368.28 ms, (p50: 2700 ms, p70: 3900, p90: 6900 ms, p99: 8400 ms), latency samples: 78465
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007 (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 13542.41 txn/s, latency: 2125.98 ms, (p50: 1900 ms, p70: 2100, p90: 2500 ms, p99: 9600 ms), latency samples: 531280
2. Upgrading first Validator to new version: 74d5a4aed0ad84677b03f2440ce94180bcaa2007
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7359.64 txn/s, latency: 3877.90 ms, (p50: 4200 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 140960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7394.95 txn/s, latency: 4345.13 ms, (p50: 4600 ms, p70: 4700, p90: 6000 ms, p99: 6400 ms), latency samples: 248400
3. Upgrading rest of first batch to new version: 74d5a4aed0ad84677b03f2440ce94180bcaa2007
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7848.00 txn/s, latency: 3504.70 ms, (p50: 3600 ms, p70: 4200, p90: 4600 ms, p99: 4800 ms), latency samples: 141960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7914.16 txn/s, latency: 4035.66 ms, (p50: 4100 ms, p70: 4300, p90: 5800 ms, p99: 6200 ms), latency samples: 263320
4. upgrading second batch to new version: 74d5a4aed0ad84677b03f2440ce94180bcaa2007
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11880.94 txn/s, latency: 2297.20 ms, (p50: 2400 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 205900
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11287.38 txn/s, latency: 2738.41 ms, (p50: 2500 ms, p70: 2700, p90: 4700 ms, p99: 5700 ms), latency samples: 367060
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 74d5a4aed0ad84677b03f2440ce94180bcaa2007 passed
Test Ok

@sherry-x sherry-x merged commit ce1cfd5 into main Sep 25, 2024
46 of 48 checks passed
@sherry-x sherry-x deleted the timeless-main branch September 25, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants