Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune replay granularity for speed #14729

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Tune replay granularity for speed #14729

merged 1 commit into from
Sep 24, 2024

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Sep 24, 2024

Description

mainnet: max-versions-per-range: 1M -> 0.8M,
testnet: max-versions-per-range: 1.8M -> 2M

6 more jobs (30-ish machines running for slightly shorter though), 30min less total time.

https://github.com/aptos-labs/aptos-core/actions/runs/11002942898
https://github.com/aptos-labs/aptos-core/actions/runs/11000410306

How Has This Been Tested?

test runs, see summary

Key Areas to Review

Type of Change

  • Tests

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

mainnet: max-versions-per-range: 1M -> 0.8M,
testnet: max-versions-per-range: 1.8M -> 2M
@msmouse msmouse requested a review from a team as a code owner September 24, 2024 00:21
Copy link

trunk-io bot commented Sep 24, 2024

@msmouse msmouse enabled auto-merge (squash) September 24, 2024 00:23

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c

two traffics test: inner traffic : committed: 14472.08 txn/s, latency: 2744.66 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3500 ms), latency samples: 5505140
two traffics test : committed: 99.95 txn/s, latency: 1621.54 ms, (p50: 1500 ms, p70: 1500, p90: 1600 ms, p99: 10600 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.240, avg: 0.227", "QsPosToProposal: max: 1.079, avg: 1.049", "ConsensusProposalToOrdered: max: 0.314, avg: 0.291", "ConsensusOrderedToCommit: max: 0.413, avg: 0.398", "ConsensusProposalToCommit: max: 0.705, avg: 0.689"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 3064105 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.59s no progress at version 3064103 (avg 8.59s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c (PR)
Upgrade the nodes to version: 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1191.49 txn/s, submitted: 1193.94 txn/s, failed submission: 2.45 txn/s, expired: 2.45 txn/s, latency: 2670.60 ms, (p50: 2400 ms, p70: 2700, p90: 4800 ms, p99: 5900 ms), latency samples: 106800
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1223.45 txn/s, submitted: 1225.69 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2496.52 ms, (p50: 2400 ms, p70: 2600, p90: 3600 ms, p99: 5200 ms), latency samples: 109040
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c passed
Upgrade the remaining nodes to version: 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1184.89 txn/s, submitted: 1187.58 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2512.69 ms, (p50: 2400 ms, p70: 2400, p90: 4000 ms, p99: 5500 ms), latency samples: 105680
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 14329.92 txn/s, latency: 2377.23 ms, (p50: 2200 ms, p70: 2300, p90: 2600 ms, p99: 5700 ms), latency samples: 460880
2. Upgrading first Validator to new version: 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6914.62 txn/s, latency: 4078.98 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5200 ms), latency samples: 128040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6611.13 txn/s, latency: 4826.19 ms, (p50: 5000 ms, p70: 5100, p90: 6700 ms, p99: 7000 ms), latency samples: 218860
3. Upgrading rest of first batch to new version: 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7348.87 txn/s, latency: 3710.45 ms, (p50: 4200 ms, p70: 4500, p90: 4700 ms, p99: 5000 ms), latency samples: 133540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7188.61 txn/s, latency: 4411.50 ms, (p50: 4600 ms, p70: 4800, p90: 6200 ms, p99: 6500 ms), latency samples: 239720
4. upgrading second batch to new version: 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1738.37 txn/s, latency: 15867.09 ms, (p50: 18400 ms, p70: 20700, p90: 24500 ms, p99: 25400 ms), latency samples: 56020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11393.44 txn/s, latency: 2716.65 ms, (p50: 2400 ms, p70: 2500, p90: 2800 ms, p99: 7200 ms), latency samples: 401140
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 62c5a4ae0a3b9b5aa12da243e1b29ab0a636c04c passed
Test Ok

@msmouse msmouse merged commit 22eea87 into main Sep 24, 2024
90 of 96 checks passed
@msmouse msmouse deleted the 0921-alden-tune-ranges branch September 24, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants