Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve rust-setup error #14721

Merged
merged 1 commit into from
Sep 23, 2024
Merged

resolve rust-setup error #14721

merged 1 commit into from
Sep 23, 2024

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Sep 23, 2024

Description

I put in the if- condition to speed up iteration on PRs, and it looks like when the condition is not hit, rust-cache is not happy with it. Removing to unbreak main.

Error:
aptos-labs/aptos-core/main/.github/actions/rust-setup/action.yaml: The
scalar style 'SingleQuoted' on line 23 and column 11 is not valid with
the tag '!startsWith(github.ref,'
Error: System.ArgumentException: Unexpected type '' encountered while
reading 'action manifest root'. The type 'MappingToken' was expected.
   at
   GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertMapping(TemplateToken
   value, String objectDescription)
      at
      GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext
      executionContext, String manifestFile)
      Error: Failed to load
      aptos-labs/aptos-core/main/.github/actions/rust-setup/action.yaml

How Has This Been Tested?

test replay-verify run

https://github.com/aptos-labs/aptos-core/actions/runs/10999817290

Key Areas to Review

Type of Change

  • Bug fix

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure

I put in the if- condition to speed up iteration on PRs, and it looks
like when the condition is not hit, rust-setup is not happy with it.
Removing to unbreak main.

```
Error:
aptos-labs/aptos-core/main/.github/actions/rust-setup/action.yaml: The
scalar style 'SingleQuoted' on line 23 and column 11 is not valid with
the tag '!startsWith(github.ref,'
Error: System.ArgumentException: Unexpected type '' encountered while
reading 'action manifest root'. The type 'MappingToken' was expected.
   at
   GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertMapping(TemplateToken
   value, String objectDescription)
      at
      GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext
      executionContext, String manifestFile)
      Error: Failed to load
      aptos-labs/aptos-core/main/.github/actions/rust-setup/action.yaml
```
@msmouse msmouse requested a review from a team as a code owner September 23, 2024 17:59
Copy link

trunk-io bot commented Sep 23, 2024

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-cargo-deny 3m 🟩
general-lints 3m 🟩
check-dynamic-deps 2m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 59s
semgrep/ci 51s 🟩🟩
file_change_determinator 26s 🟩🟩
file_change_determinator 22s 🟩🟩
replay-mainnet / prepare 9s 🟥
Backport PR 8s 🟥🟥
determine-test-metadata 8s 🟩
permission-check 6s 🟩🟩
permission-check 5s 🟩🟩
permission-check 5s 🟩🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@msmouse msmouse added the CICD:test-replay Trigger a testnet replay-verify job for this PR label Sep 23, 2024
@perryjrandall perryjrandall merged commit 590e1f5 into main Sep 23, 2024
92 of 101 checks passed
@perryjrandall perryjrandall deleted the 0923-alden-remove-hack branch September 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:test-replay Trigger a testnet replay-verify job for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants