-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically bump Forge compat base image to latest release #14686
Merged
yzaccc
merged 12 commits into
main
from
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
Sep 26, 2024
Merged
Automatically bump Forge compat base image to latest release #14686
yzaccc
merged 12 commits into
main
from
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzaccc
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Sep 18, 2024
yzaccc
force-pushed
the
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
branch
from
September 18, 2024 23:43
c136225
to
ad21dc2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yzaccc
force-pushed
the
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
branch
from
September 19, 2024 00:15
cec5dcc
to
ec40ae2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yzaccc
force-pushed
the
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
branch
2 times, most recently
from
September 19, 2024 04:08
195bb2c
to
483cb23
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yzaccc
force-pushed
the
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
branch
2 times, most recently
from
September 19, 2024 06:17
370a94b
to
df93f9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
yzaccc
deleted the
yzaccc/auto-bump-forge-compat-base-image-to-latest-release
branch
September 26, 2024 01:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Determine the IMAGE_TAG based on the latest release R and check for images built on branch R - 1:
- For commits on the
aptos-release-v1.19
branch, theIMAGE_TAG
should be the latest commit built onaptos-release-v1.18
- For commits on the
main
branch, theIMAGE_TAG
should be the latest commit on the max releaseaptos-release-v<MAX>
branch- For commits on other branches, the IMAGE_TAG should be the latest commit on the branch's last release aptos-release-v<X.X> branch
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
locally:
poetry run python3 -u determine_target_branch_to_fetch_last_released_image.py main Target branch is aptos-release-v1.20 aptos-release-v1.20
poetry run python3 -u determine_target_branch_to_fetch_last_released_image.py aptos-release-v1.19 Target branch is aptos-release-v1.18 aptos-release-v1.18
Tested in current PR's CI https://github.com/aptos-labs/aptos-core/actions/runs/11007566097
Created unitests.
Key Areas to Review
Checklist