[framework] introduce private entry function for creating multisig account #14645

yeptos · 2024-09-15T09:57:05Z

Description

Introduce private entry functions for creating multisig account. This eliminates the need for generating the complex proof the existing create_with_existing_account functions require.

This proposal mirrors changes implemented in commits fdc041f d771cec, where a private entry function was introduced for account key rotation with a similar purpose.

AIP proposal: aptos-foundation/AIPs#496

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Added unit tests

Key Areas to Review

The implementation itself is straightforward, please see the AIP for the rationale of this change.

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-15T09:57:08Z

⏱️ 29m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	14m	🟩
rust-move-tests	9m	🟩
general-lints	2m	🟩
rust-cargo-deny	2m	🟩
check-dynamic-deps	1m	🟩
semgrep/ci	43s	🟩
file_change_determinator	11s	🟩
permission-check	4s	🟥
permission-check	3s	🟥
permission-check	2s	🟥
permission-check	2s	🟥

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

movekevin · 2024-09-27T01:39:25Z

Can you add an integration test under api/ for this as well?

yeptos · 2024-09-28T09:09:56Z

@movekevin added a minimal test case under api/ 3b7e10f

…count This eliminates the need for generating the complex proof the existing create_with_existing_account functions require.

github-actions · 2024-10-02T00:27:35Z

✅ Forge suite `realistic_env_max_load` success on `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`

two traffics test: inner traffic : committed: 14517.47 txn/s, latency: 2736.95 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5519960
two traffics test : committed: 99.94 txn/s, latency: 1498.10 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 2000 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.222", "QsPosToProposal: max: 1.100, avg: 1.060", "ConsensusProposalToOrdered: max: 0.329, avg: 0.291", "ConsensusOrderedToCommit: max: 0.425, avg: 0.403", "ConsensusProposalToCommit: max: 0.713, avg: 0.694"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 3039921 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.63s no progress at version 3039919 (avg 8.63s) [limit 15].
Test Ok

github-actions · 2024-10-02T00:29:32Z

✅ Forge suite `framework_upgrade` success on `7ef01a26f8d8a38610e3d364b722df517c970749` ==> `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9 (PR)
Upgrade the nodes to version: 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1284.30 txn/s, submitted: 1286.80 txn/s, failed submission: 2.51 txn/s, expired: 2.51 txn/s, latency: 2539.88 ms, (p50: 2100 ms, p70: 2400, p90: 4100 ms, p99: 6000 ms), latency samples: 112760
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1237.52 txn/s, submitted: 1240.17 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2456.76 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5900 ms), latency samples: 111880
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9 passed
Upgrade the remaining nodes to version: 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1153.47 txn/s, submitted: 1156.77 txn/s, failed submission: 3.30 txn/s, expired: 3.30 txn/s, latency: 2514.86 ms, (p50: 2400 ms, p70: 2700, p90: 3400 ms, p99: 5400 ms), latency samples: 104800
Test Ok

github-actions · 2024-10-02T00:36:38Z

✅ Forge suite `compat` success on `7ef01a26f8d8a38610e3d364b722df517c970749` ==> `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9 (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 15035.94 txn/s, latency: 2238.49 ms, (p50: 2100 ms, p70: 2200, p90: 2700 ms, p99: 5400 ms), latency samples: 488320
2. Upgrading first Validator to new version: 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7325.21 txn/s, latency: 3893.93 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 134860
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6593.01 txn/s, latency: 4816.54 ms, (p50: 4700 ms, p70: 4800, p90: 7200 ms, p99: 7400 ms), latency samples: 236400
3. Upgrading rest of first batch to new version: 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6767.71 txn/s, latency: 4168.80 ms, (p50: 4800 ms, p70: 5000, p90: 5100 ms, p99: 5300 ms), latency samples: 126260
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6686.71 txn/s, latency: 4703.09 ms, (p50: 4800 ms, p70: 4900, p90: 6900 ms, p99: 7400 ms), latency samples: 222020
4. upgrading second batch to new version: 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11843.88 txn/s, latency: 2318.65 ms, (p50: 2600 ms, p70: 2600, p90: 2800 ms, p99: 2900 ms), latency samples: 206320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11900.00 txn/s, latency: 2687.67 ms, (p50: 2600 ms, p70: 2800, p90: 3000 ms, p99: 3400 ms), latency samples: 383400
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9 passed
Test Ok

yeptos requested review from davidiw, movekevin and wrwg as code owners September 15, 2024 09:57

gregnazario approved these changes Sep 18, 2024

View reviewed changes

movekevin approved these changes Sep 27, 2024

View reviewed changes

yeptos force-pushed the multisig-v2-create-from-existing-signer branch from cb6f3a8 to 449e4ac Compare September 28, 2024 07:42

yeptos requested review from banool and 0xmaayan as code owners September 28, 2024 07:42

yeptos force-pushed the multisig-v2-create-from-existing-signer branch from 449e4ac to 3b7e10f Compare September 28, 2024 08:58

yeptos added 3 commits September 30, 2024 20:47

[framework] introduce private entry function for creating multisig ac…

414b248

…count This eliminates the need for generating the complex proof the existing create_with_existing_account functions require.

add an integration test

f01f482

fix arg names

524333a

sherry-x force-pushed the multisig-v2-create-from-existing-signer branch from 9b812ec to 524333a Compare October 1, 2024 03:47

sherry-x enabled auto-merge (rebase) October 1, 2024 03:47

This comment has been minimized.

Sign in to view

gregnazario approved these changes Oct 1, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

fix lint

27ff60d

auto-merge was automatically disabled October 1, 2024 04:16
Head branch was pushed to by a user without write access

sherry-x enabled auto-merge (rebase) October 2, 2024 00:01

This comment has been minimized.

Sign in to view

sherry-x merged commit 7f784af into aptos-labs:main Oct 2, 2024
93 of 95 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[framework] introduce private entry function for creating multisig account #14645

[framework] introduce private entry function for creating multisig account #14645

yeptos commented Sep 15, 2024

trunk-io bot commented Sep 15, 2024 •

edited

Loading

movekevin commented Sep 27, 2024

yeptos commented Sep 28, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

[framework] introduce private entry function for creating multisig account #14645

[framework] introduce private entry function for creating multisig account #14645

Conversation

yeptos commented Sep 15, 2024

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 15, 2024 • edited Loading

movekevin commented Sep 27, 2024

yeptos commented Sep 28, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 2, 2024

✅ Forge suite realistic_env_max_load success on 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9

github-actions bot commented Oct 2, 2024

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9

github-actions bot commented Oct 2, 2024

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 27ff60d41b8cbd1110b9218abcf3c8e754e30ea9

trunk-io bot commented Sep 15, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`

✅ Forge suite `framework_upgrade` success on `7ef01a26f8d8a38610e3d364b722df517c970749` ==> `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`

✅ Forge suite `compat` success on `7ef01a26f8d8a38610e3d364b722df517c970749` ==> `27ff60d41b8cbd1110b9218abcf3c8e754e30ea9`