create permissioned signer example #14469
Draft
+2,129
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 46m total CI duration on this PR
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14469 +/- ##
========================================
Coverage 60.0% 60.1%
========================================
Files 856 856
Lines 210625 211026 +401
========================================
+ Hits 126555 126865 +310
- Misses 84070 84161 +91 ☔ View full report in Codecov by Sentry. |
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
2 times, most recently
from
887d7a2
to
456f5f4
Compare
21 tasks
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
2 times, most recently
from
55771fc
to
070a951
Compare
21 tasks
runtian-zhou
commented
Sep 5, 2024
| } | ||
|
|
||
| /// Another flavor of api to extract and store permissions | ||
| public fun extract_permission<PermKey: copy + drop + store>( |
rahxephon89
reviewed
Sep 6, 2024
| }; | ||
| let perms = &mut borrow_global_mut<PermStorage>(permission_signer_addr).perms; | ||
| let key = copyable_any::pack(key); | ||
| if(smart_table::cotains(perms, key)) { |
There was a problem hiding this comment.
typo: cotains => contains
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
3 times, most recently
from
6ddb481
to
8b92b98
Compare
21 tasks
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
from
8b92b98
to
fa646c8
Compare
21 tasks
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
2 times, most recently
from
c3aba3a
to
50b556b
Compare
lightmark
reviewed
Sep 16, 2024
| }; | ||
| let (found, idx) = vector::index_of(&granted_permissions.revoked_handles, &permission_addr); | ||
| if(found) { | ||
| vector::swap_remove(&mut granted_permissions.revoked_handles, idx); |
lightmark
reviewed
Sep 16, 2024
|
|
||
| struct GrantedPermissionHandles has key { | ||
| active_handles: vector<address>, | ||
| revoked_handles: vector<address>, |
lightmark
reviewed
Sep 16, 2024
| expiration_time: u64 | ||
| ): PermissionedHandle acquires GrantedPermissionHandles { | ||
| assert!(!is_permissioned_signer(master), error::permission_denied(ENOT_MASTER_SIGNER)); | ||
| let permission_addr = generate_auid_address(); |
There was a problem hiding this comment.
could we make sure there is neither object nor account exists on this address?
lightmark
reviewed
Sep 16, 2024
| signer::address_of(master) == signer::address_of(permissioned), | ||
| error::permission_denied(ECANNOT_AUTHORIZE) | ||
| ); | ||
| let permission_signer = permission_signer(permissioned); |
There was a problem hiding this comment.
this line is so confusing.
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
3 times, most recently
from
1b8ce69
to
c7fcc0e
Compare
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
3 times, most recently
from
ae32259
to
a12a4c1
Compare
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
2 times, most recently
from
23ab901
to
e963d83
Compare
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
from
e963d83
to
e7391d6
Compare
runtian-zhou
force-pushed
the
08-29-create_permissioned_signer_example
branch
from
e7391d6
to
2cee592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist