-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeltaApplicationError & predicted value fixes, error fallbacks #14422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gelash
requested review from
runtian-zhou,
sasha8,
danielxiangzl,
zekun000 and
georgemitenkov
as code owners
August 26, 2024 19:27
⏱️ 50m total CI duration on this PR
|
gelash
changed the title
DeltaApplicationError & latest predicted value fixes, fallbacks to se…
DeltaApplicationError & predicted value fixes, more fallbacks
Aug 26, 2024
gelash
changed the title
DeltaApplicationError & predicted value fixes, more fallbacks
DeltaApplicationError & predicted value fixes, error fallbacks
Aug 26, 2024
igor-aptos
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment inline, rest looks good!
gelash
commented
Aug 29, 2024
igor-aptos
added
CICD:run-execution-performance-test
Run execution performance test
CICD:run-execution-performance-full-test
Run execution performance test (full version)
labels
Sep 5, 2024
gelash
force-pushed
the
gelash/deltaerrorfixes
branch
from
September 6, 2024 09:23
4a77084
to
de0146c
Compare
gelash
requested review from
a team,
msmouse,
lightmark,
grao1991,
JoshLind,
gregnazario,
banool,
bchocho,
ibalajiarun,
davidiw,
movekevin,
wrwg and
vgao1996
as code owners
September 6, 2024 09:23
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gelash
force-pushed
the
gelash/deltaerrorfixes
branch
from
September 30, 2024 21:31
2c2ee21
to
3e28364
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gelash
force-pushed
the
gelash/deltaerrorfixes
branch
from
September 30, 2024 22:26
3e28364
to
0f11f05
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gelash
force-pushed
the
gelash/deltaerrorfixes
branch
from
October 2, 2024 17:15
0f11f05
to
927d85d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
CICD:run-execution-performance-full-test
Run execution performance test (full version)
CICD:run-execution-performance-test
Run execution performance test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added new tests for changing functionality, and passes existing tests.