-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bollard crate directly, upgrade serde to 1.0.152 #10546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes us from using my Bollard fork that uses an older serde_with version to using the main Bollard crate. Recently I landed a PR to serde_with that changed the minimum required serde version from 1.0.157 to 1.0.152. Bollard uses serde_with, so now the transitive dependency on serde through serde_with from Bollard is no longer 1.0.157 but 1.0.152, which we can use happily without breaking the the analyze formats code (see this issue for more details: ).
banool
changed the title
Use bollard crate directly
Use bollard crate directly, upgrade serde to 1.0.152
Oct 17, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
bowenyang007
approved these changes
Oct 17, 2023
larry-aptos
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes us from using my Bollard fork that uses an older serde_with version to using the main Bollard crate.
Recently I landed a PR to serde_with that changed the minimum required serde version from 1.0.157 to 1.0.152: jonasbb/serde_with#653. Bollard uses serde_with, so now the transitive dependency on serde through serde_with from Bollard is no longer 1.0.157 but 1.0.152, which we can use happily without breaking the the analyze formats code (see this issue for more details: #10424).
Test Plan