Fix setting of G4Touchable when giving track back to G4 #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
JuanGonzalezCaminero
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR fixes the handling of the G4Touchable when tracks are returned to G4.
As the UserStackingAction might check on the Touchable or NextTouchable, they must be set before giving it back to G4. This caused a crash in CMSSW.
At the same time, previously, every step was located in G4 when given to AdePT via
SetInitialStep(see https://gitlab.cern.ch/geant4/geant4/-/blob/master/source/tracking/src/G4SteppingManager.cc?ref_type=heads#L309-L326). Now, this is called only for initial Steps (step number == 0).This change slightly improves performance for offloading only the HCAL and ECAL in example1 using the CMS2018 geometry.
Also a minor cleaning was done: the
FillG4NavigationHistorynow receives a const reference instead of by value.