Skip to content

fix: competition filter not updating correctly (#148) #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −13
Open

fix: competition filter not updating correctly (#148) #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions apps/web/src/components/ui/Filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,14 @@ export default function Filter({
filters: string[];
onClick?: () => void;
}) {
const { updateFilters } = useFilterInputStore();
const inputData: { [key: string]: string } = {};
const { filters: selectedFilters, updateFilters } = useFilterInputStore();

const recordFilterInput = (filter: string) => {
inputData[filterName] = filter;
updateFilters(inputData);
updateFilters({ [filterName]: filter });
};

const triggerClasses = clsx("text-sm font-medium", {
"text-slate-300": ["Hire contributors", "Funding", "Trending"].includes(
filterName
),
"text-slate-300": ["Hire contributors", "Funding", "Trending"].includes(filterName),
});

return (
Expand All @@ -35,18 +32,21 @@ export default function Filter({
<span className="text-sm font-medium text-white">{filterName}</span>
</AccordionTrigger>
<AccordionContent className="pt-1 pb-3">
<RadioGroup className="space-y-3">
<RadioGroup
className="space-y-3"
// ✅ Controlled selection: reads from Zustand state
value={selectedFilters[filterName] || ""}
onValueChange={(val) => recordFilterInput(val)}
>
{filters.map((filter) => (
<div key={filter} className="flex items-center space-x-3">
<RadioGroupItem
value={filter}
id={filter}
onClick={() => recordFilterInput(filter)}
id={`${filterName}-${filter}`}
className="border-[#28282c] bg-[#141418] text-ox-purple transition data-[state=checked]:border-ox-purple data-[state=checked]:bg-ox-purple/20 data-[state=checked]:ring-2 data-[state=checked]:ring-ox-purple/50"
/>
<Label
htmlFor={filter}
onClick={() => recordFilterInput(filter)}
htmlFor={`${filterName}-${filter}`}
className="text-sm text-zinc-300 cursor-pointer transition-colors"
>
{filter}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/store/useFilterInputStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { create } from "zustand";

interface FilterInputState {
filters: object;
filters: Record<string, string>;
updateFilters: (newFilter: Record<string, string>) => void;
resetFilters: () => void;
}
Expand Down