Fix React Native 0.62 compatability

[KDederichs]

Fix double include of CocoaAsyncSocket in RN 0.62 since it's there by default now.

[chrmod]

Can we please get it merged and released?

[KDederichs]

While you wait I suggest just removing those via
https://github.com/ds300/patch-package#readme
@chrmod
It at least helps moving forward (at least that's what I did while I wait for it to merge)

[chrmod]

@KDederichs thanks for the suggestion. Will this work in this case? The root of the proplem is cocoapod not nodejs package. Have you published your fix maybe? I'm eager to use it a POC I'm working on.

[KDederichs]

@chrmod Yes it does work since the Pod code is shipped in the node package.
Here's a gist with my patch file, since like I said I'm just using patch-package since I have it set up for other libraries that stubbornly refuse to fix their stuff.

https://gist.github.com/KDederichs/5ba8ff22b12f4433a4ce5e0ce63b98d0

It's basically this pull request as file.

[chrmod]

@KDederichs this works great. Thank you!

[ArshanKhanifar]

What's the status on this? When is it going to get merged? 😇 I'm using patch-package but would like not to do so.

[compojoom]

@KDederichs - thanks for this pull request. I just wanted to create the same as I was integrating flipper on iOS and ran into that problem.

@aprock can we get this merged please?

In the meantime as @KDederichs suggested you can use patch-package to remove CocoaAsyncSocket

[aprock]

merged

[compojoom]

A new release would be also very cool :)

[roaringUnicorn]

I'd love a release too !

[ReactNativeDev2296]

we are facing crash issue when get permission of local network and get error tcp socket is not connected @phillbaker @aprock please help,
crashing log
`*** First throw call stack:

(0x1a154f25c 0x1b52e4480 0x1027128dc 0x10278f150 0x10278fb88 0x1a1553a10 0x1a1435720 0x1a1435c84 0x1027429b0 0x102744b44 0x1027448a8 0x104333ae8 0x10433532c 0x10433c38c 0x10433d010 0x104348820 0x1e9b595bc 0x1e9b5c86c)

libc++abi: terminating with uncaught exception of type NSException

*** Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: Error: Socket is not connected.', reason: 'Unhandled JS Exception: Error: Socket is not connected., stack:

@1320:4943

w@1331:1755

b@1331:1629

@1331:3542

@1171:9295

y@129:580

callTimers@129:2629

value@25:3350

@25:747

value@25:2610

value@25:719

value@(null):(null)

'

terminating with uncaught exception of type NSException`
React native version:-0.63.1,
IOS version:14.7,
RN-tcp:-4.0.0