Skip to content

Upgrade for Android API 29 , using gradle 6, react-native 0.61+, test… #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aprock merged 1 commit into from
Apr 9, 2020
Merged

Upgrade for Android API 29 , using gradle 6, react-native 0.61+, test… #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions TcpServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@
* @flow
*/

'use strict';

var util = require('util');
var EventEmitter = require('events').EventEmitter;
var {
NativeModules
} = require('react-native');
var { NativeModules } = require('react-native');
var Sockets = NativeModules.TcpSockets;

var Socket = require('./TcpSocket');
Expand All @@ -31,16 +27,16 @@ function TcpServer(connectionListener: (socket: Socket) => void) {
this._socket = new Socket();

// $FlowFixMe: suppressing this error flow doesn't like EventEmitter
this._socket.on('connect', function() {
this._socket.on('connect', function () {
Copy link
Collaborator

@phillbaker phillbaker Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate out these formatting changes into a separate PR?

self.emit('listening');
});
// $FlowFixMe: suppressing this error flow doesn't like EventEmitter
this._socket.on('connection', function(socket) {
this._socket.on('connection', function (socket) {
self._connections++;
self.emit('connection', socket);
});
// $FlowFixMe: suppressing this error flow doesn't like EventEmitter
this._socket.on('error', function(error) {
this._socket.on('error', function (error) {
self.emit('error', error);
});

Expand All @@ -53,15 +49,15 @@ function TcpServer(connectionListener: (socket: Socket) => void) {

util.inherits(TcpServer, EventEmitter);

TcpServer.prototype._debug = function() {
TcpServer.prototype._debug = function () {
if (__DEV__) {
var args = [].slice.call(arguments);
console.log.apply(console, args);
}
};

// TODO : determine how to properly overload this with flow
TcpServer.prototype.listen = function() : TcpServer {
TcpServer.prototype.listen = function (): TcpServer {
var args = this._socket._normalizeConnectArgs(arguments);
var options = args[0];
var callback = args[1];
Expand All @@ -79,17 +75,23 @@ TcpServer.prototype.listen = function() : TcpServer {
return this;
};

TcpServer.prototype.getConnections = function(callback: (err: ?any, count: number) => void) {
TcpServer.prototype.getConnections = function (
callback: (err: ?any, count: number) => void,
) {
if (typeof callback === 'function') {
callback.invoke(null, this._connections);
}
};

TcpServer.prototype.address = function() : { port: number, address: string, family: string } {
TcpServer.prototype.address = function (): {
port: number,
address: string,
family: string,
} {
return this._socket ? this._socket.address() : {};
};

TcpServer.prototype.close = function(callback: ?() => void) {
TcpServer.prototype.close = function (callback: ?() => void) {
if (typeof callback === 'function') {
if (!this._socket) {
this.once('close', function close() {
Expand All @@ -111,6 +113,8 @@ TcpServer.prototype.close = function(callback: ?() => void) {
};

// unimplemented net.Server apis
TcpServer.prototype.ref = TcpServer.prototype.unref = function() { /* nop */ };
TcpServer.prototype.ref = TcpServer.prototype.unref = function () {
/* nop */
};

module.exports = TcpServer;
Loading