KF-23 fix USimpleString::matches #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belyshevdenis
requested changes
Aug 4, 2025
belyshevdenis
requested changes
Aug 4, 2025
belyshevdenis
requested changes
Aug 5, 2025
belyshevdenis
approved these changes
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the USimpleString::matches method to be IRQL independent and adds comprehensive test coverage for wildcard matching functionality.
- Adds comprehensive unit tests for USimpleString::matches and USimpleString::matchesIgnoreCase methods
- Adds test file to CMakeLists.txt build configuration
- Renames existing test files from HexTest.cpp/MapTest.cpp to Hex.cpp/Map.cpp for consistency
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/USimpleString.cpp | Comprehensive test suite for USimpleString wildcard matching functionality with '*' and '?' patterns |
| test/CMakeLists.txt | Updates build configuration to include new test file and renames existing test files |
Collaborator
|
@Kellesi please revert the renaming of Hex and Map tests to originals |
Collaborator
|
@SergiusTheBest do you mind? this branch is the part of another one with strings testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make USimpleString::matches IRQL independent
Add tests for it
Task: https://jira.dev.local/jira/browse/KF-23