Skip to content

Update Heading.svelte #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Update Heading.svelte #2104

merged 2 commits into from
Jun 16, 2025

Conversation

thejessewinton
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

appwrite bot commented Jun 13, 2025

appwrite.io

Project ID: 684969cb000a2f6c0a02

Sites (1)
Site Status Logs Preview QR
 website
68496a17000f03d62013
Failed Failed View Logs Preview URL QR Code

Note

Cursor pagination performs better than offset pagination when loading further pages.

@stnguyen90 stnguyen90 self-requested a review June 13, 2025 21:27
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some odd behavior while testing locally.

  1. hydration errors
  2. the fragment wasn't right when the page first loaded and then it updated to be correct

Let's make sure to validate it everything works smoothly when deployed.

@thejessewinton thejessewinton merged commit 76983e6 into main Jun 16, 2025
3 of 4 checks passed
@stnguyen90 stnguyen90 deleted the integration-headings-fix branch June 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants