Update Flutter SDK to add offline support #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
feat-os-flutter
branch
from
00e5b11 to
6358c99
Compare
lohanidamodar
approved these changes
Feb 19, 2023
stnguyen90
force-pushed
the
feat-os-flutter
branch
3 times, most recently
from
02fb129 to
9e7e0c4
Compare
@lohanidamodar, what were you thinking we would do for the mock endpoints? |
Can we have mock endpoints with cache labels, and may be run test and check if data is cached? |
src/Spec/Swagger2.php
Outdated
| 'offline' => [ | ||
| 'model' => $method['x-appwrite']['offline-model'] ?? '', | ||
| 'key' => $method['x-appwrite']['offline-key'] ?? '', | ||
| 'model' => $method['x-appwrite']['offline-model'] ?? '', |
There was a problem hiding this comment.
Suggested change
| 'model' => $method['x-appwrite']['offline-model'] ?? '', |
Looks like this was defined twice
tests/languages/dart/tests.dart
Outdated
| @@ -114,7 +114,7 @@ void main() async { | |||
| print(Permission.update(Role.user(ID.custom('userid'), 'unverified'))); | |||
|
|
|||
| // ID helper tests | |||
| print(ID.unique()); | |||
| // print(ID.unique()); | |||
There was a problem hiding this comment.
we can remove this or we can test this by printing twice making sure it gives back unique ID each time?
tests/languages/flutter/tests.dart
Outdated
| @@ -147,7 +147,7 @@ void main() async { | |||
| print(Permission.update(Role.user(ID.custom('userid'), 'unverified'))); | |||
|
|
|||
| // ID helper tests | |||
| print(ID.unique()); | |||
| // print(ID.unique()); | |||
stnguyen90
force-pushed
the
feat-os-flutter
branch
3 times, most recently
from
603ae18 to
b37f539
Compare
2 tasks
|
@lohanidamodar, I've updated the PR based on your feedback including adding the mock labels: appwrite/appwrite#5160 |
stnguyen90
force-pushed
the
feat-os-flutter
branch
5 times, most recently
from
3a1a9e2 to
50950e3
Compare
stnguyen90
force-pushed
the
feat-os-flutter
branch
from
50950e3 to
d651cec
Compare
abnegate
reviewed
Mar 8, 2023
stnguyen90
force-pushed
the
feat-os-flutter
branch
from
d651cec to
3aa4cf3
Compare
abnegate
approved these changes
Mar 9, 2023
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the Flutter SDK to add Offline Support.
Test Plan
Manual
Related PRs and Issues
TODO
Have you read the Contributing Guidelines on issues?
Yes