Skip to content

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Jan 30, 2026

What does this PR do?

Before:

image

After:

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes
    • Deployment status now shows "Ready" instead of "Finalizing" during finalization across deployment views.
    • Unified status labels in deployment cards, function tables, and deployment logs.
    • Improved clarity and consistency for deployment readiness shown to end-users.
    • Ensures a consistent status representation throughout the application.

✏️ Tip: You can customize this high-level summary in your review settings.

@appwrite
Copy link

appwrite bot commented Jan 30, 2026

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Sites auto-generate unique domains with the pattern https://randomstring.appwrite.network

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Walkthrough

Three Svelte components were updated to normalize status rendering. Each adds a derived displayStatus that maps finalizing to ready and otherwise mirrors effectiveStatus. UI bindings and calls to deploymentStatusConverter were switched from effectiveStatus to displayStatus. No control-flow, API, or exported declarations were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing deployments stuck in 'Finalizing' status by mapping them to display as 'Ready' instead.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-functions-finalizing-status

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 requested review from ItzNotABug and Meldiron and removed request for ItzNotABug January 30, 2026 12:03
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@src/routes/`(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte:
- Line 42: displayStatus is being inferred as string but the Status component
expects a specific union type; update the assignment to assert the correct union
type (e.g., cast the value to the shared Status type) so it matches the Status
component prop. Locate the displayStatus declaration and change the expression
to include a type assertion (or import and use the shared
DeploymentStatus/Status type) for the derived value so the type-checker accepts
passing displayStatus into the Status component.
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte (1)

46-46: Consider adding type assertion for consistency.

While this file doesn't have a type error (since both consumers accept string), consider adding the same type assertion as suggested for deploymentCard.svelte to maintain consistency across the codebase and prevent future issues if displayStatus is used elsewhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const should be fine for all $deriveds 👍 .

@HarshMN2345 HarshMN2345 merged commit bd33c04 into main Jan 30, 2026
4 of 5 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-functions-finalizing-status branch January 30, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants