Skip to content

Reo #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Reo #1779

wants to merge 8 commits into from

Conversation

thejessewinton
Copy link
Contributor

What does this PR do?

Add reo to the console.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Apr 4, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-05-23 05:38:03 CET

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Apr 4, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-04-04 20:37:42 CET

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Apr 4, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-05-23 05:38:03 CET

@thejessewinton thejessewinton requested a review from ArmanNik April 4, 2025 20:34
@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Apr 4, 2025

The preview deployment failed. 🔴

Open Build Logs

Last updated at: 2025-05-16 03:35:24 CET

Copy link
Contributor Author

@thejessewinton thejessewinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thejessewinton thejessewinton requested a review from stnguyen90 May 15, 2025 09:28
@ItzNotABug ItzNotABug requested a review from stnguyen90 May 16, 2025 06:15
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now, but the identification is incomplete.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they really not have typings?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't :
I did the same thing on website as well.

@@ -274,6 +276,8 @@
$stripe = await loadStripe(VARS.PUBLIC_STRIPE_KEY);
await checkForMissingPaymentMethod();
}

identifyUserWithReo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need that once in a Layout of authenticated part of the console, that way we only have to call it once

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't trigger on after a login or a sign-in from what I remember. Thats why one on login, register and here [if already authenticated]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants