-
Notifications
You must be signed in to change notification settings - Fork 163
Reo #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reo #1779
Conversation
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-23 05:38:03 CET |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-04-04 20:37:42 CET |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-23 05:38:03 CET |
The preview deployment failed. 🔴 Last updated at: 2025-05-16 03:35:24 CET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now, but the identification is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they really not have typings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they don't :
I did the same thing on website as well.
@@ -274,6 +276,8 @@ | |||
$stripe = await loadStripe(VARS.PUBLIC_STRIPE_KEY); | |||
await checkForMissingPaymentMethod(); | |||
} | |||
|
|||
identifyUserWithReo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need that once in a Layout of authenticated part of the console, that way we only have to call it once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't trigger on after a login or a sign-in from what I remember. Thats why one on login, register and here [if already authenticated]
What does this PR do?
Add reo to the console.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)