Skip to content

Commit

Permalink
Merge pull request #33 from appuio/deprecate-ldap-pw
Browse files Browse the repository at this point in the history
Deprecated: 'bindPassword' as string parameter for LDAP IdP
  • Loading branch information
ccremer authored Sep 20, 2021
2 parents 30ac698 + e2c4dd5 commit 22069b0
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 0 deletions.
Empty file.
27 changes: 27 additions & 0 deletions docs/modules/ROOT/pages/references/deprecation-notice.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
= Deprecated features

== v2.3.0

Directly providing a Vault secret reference as a string in `openshift4_authentication.identityProviders.*.ldap.bindPassword` is **deprecated**.
Users should switch to the secret references mechanism, as documented in xref:how-tos/configure-secrets.adoc[configuring secrets for identity providers] how-to, as the legacy syntax will be removed in a future release.

See below for an example diff showing how to restructure an LDAP identity provider configuration from the legacy syntax to secret references.

[source,diff]
----
parameters:
openshift4_authentication:
identityProviders:
<name_of_the_provider>:
type: LDAP
ldap:
- bindPassword: "?{vaultkv:${customer:name}/${cluster:name}/ldap-auth/bindPassword}"
+ bindPassword:
+ name: ldap-bind <1>
+ secrets:
+ ldap-bind: <1>
+ bindPassword: '?{vaultkv:${cluster:tenant}/${cluster:name}/ldap-auth/bindPassword}' <2>
----
<1> Name of the secret containing the LDAP bind password.
The name needs to be identical in both locations.
<2> The bind password **must** be stored in key `bindPassword` in the secret.
2 changes: 2 additions & 0 deletions docs/modules/ROOT/partials/nav.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
** xref:how-tos/configure-oidc-provider.adoc[Configure OIDC provider]
** xref:how-tos/group-memberships.adoc[Manage group memberships]
* References
** xref:references/deprecation-notice.adoc[Deprecated features]

0 comments on commit 22069b0

Please sign in to comment.