[자동차 경주 게임] 김지민 미션 제출합니다. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndomNumberGenerator 테스트 추가
HubCreator
reviewed
Dec 12, 2022
| private GameStatus initRacingCars() { | ||
| ReadRacingCarsNameDto dto = ioViewResolver.resolveInputView(ReadRacingCarsNameDto.class); | ||
| MovingCarNumberGenerator generator = new StandardMovingCarRandomNumberGenerator(MOVE_MIN_VALUE, MOVE_MAX_VALUE); | ||
| racingGame = new RacingGame(dto.getRacingCarsName(), generator); |
There was a problem hiding this comment.
RacingGame 생성자의 인자에 dto에서 값을 꺼내서 전해주는 것이 좋나요? 아니면 dto 자체를 넘겨서 생성자 안에서 get을 하는 것이 좋나요??
컨벤션이나 가독성 측면에서 좋은 방법이 있는지 궁금합니다!
There was a problem hiding this comment.
@HubCreator
제가 알기로는 컨벤션으로 정해진 바는 없는 것으로 알고 있습니다.
제 경우 import문을 줄이기 위해 dto에서 값을 꺼내서 전달해주는 것을 선호하는 편입니다!
HubCreator
reviewed
Dec 12, 2022
Comment on lines
+15
to
+16
| private final String name; | ||
| private int position = 0; |
There was a problem hiding this comment.
primitive 타입과 문자열 또한 객체로 감싸는 것은 어떨까요?
String name을 객체로 만들면, 유효하지 못한 자동차 이름 검증을 해당 객체 생성자에서 validate할 수 있을 것 같습니다.
There was a problem hiding this comment.
@HubCreator
말씀하신 바가 맞습니다! 왜 떠올리지 못했는지 모르겠네요.. 감사합니다!
HubCreator
reviewed
Dec 12, 2022
Comment on lines
+35
to
+38
| @Override | ||
| public int compareTo(Car target) { | ||
| return target.position - this.position; | ||
| } |
There was a problem hiding this comment.
Integer.compare(target.position, this.position)으로 나타내는 방법도 있네요!
HubCreator
reviewed
Dec 12, 2022
Comment on lines
+35
to
+36
| return gameStatusMappings.get(gameStatus).get(); | ||
| } |
There was a problem hiding this comment.
@HubCreator
헉 그러네요 완전히 빠져버렸네요 ㄷㄷ 감사합니다! 시간날 때 리펙토링을 해야겠네요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.