Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing *.spec.tsx pattern in multiple tsconfig.spec.json files #557

Merged
merged 1 commit into from
May 17, 2024

Conversation

emil-litwiniec
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

...*.spec.tsx was missing from include array in tsconfig.spec.json files across multiple internal packages. That led to many ts errors shown by language server inside editors with missing type declarations etc.

Screenshot 2024-05-16 at 14 13 25

@emil-litwiniec emil-litwiniec requested a review from mkleszcz May 16, 2024 12:31
@emil-litwiniec emil-litwiniec merged commit 9dfcd51 into master May 17, 2024
53 checks passed
@emil-litwiniec emil-litwiniec deleted the fix/missing-spec-tsx-file-from-tsconfig branch May 17, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants