Add --no-mount to override (disable) singularity.conf mount options #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes: #5081 It has been requested that users can turn off mount options set to `yes` in `singularity.conf` as they may interfere with some containers - especially when `mount hostfs = yes` is set. In #5086 a single `--no-hostfs` flag was introduced but concern was raised that we should be able to disable all, and this would lead to a proliferation of flags. Another viewpoint is that we should have all of the `--no-xxxxx` flags. This PR proposes a middle ground. Add a `--no-mount` flag that can take one or more 'mounts' to disable, overriding the `singularity.conf` value. I feel this is more clear / friendlier than using `--mount ^hostfs` negation syntax. Implemented through individual NoXXXX booleans on the EngineConfig so it'd be trivial to add the `--no-xxxx` CLI flags later if we change our minds.
Note this does not test for `--no-mount hostfs` yet. See TODO in `e2e/actions/actions.go`
dtrudg
changed the title
cclerget
reviewed
Nov 6, 2020
Added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is proposed as an alternative to the single
--no-hostfsin #5086, but I'm very open to any of:--no-mountapproach.--no-hostfsby re-opening Add --no-hostfs actions flag #5086--no-xxxflags for eachmount xxxconfig option by modifying this PR.My opinion r.e. the previous discussion in #5086 is that as we have an existing
--no-xxxpattern for flags, the proposal in#5086comments of a--mount ^xxxxnegation syntax is confusing. Also if we allow positive overrides via a--mountwe need to worry about precedence / behavior when user binds are disabled etc. For positive overrides (mounting things disabled insingularity.conf)--bind/-Bis already available, with understood semantics.Description of the Pull Request (PR):
It has been requested that users can turn off mount options set to
yesin
singularity.confas they may interfere with some containers -especially when
mount hostfs = yesis set.In #5086 a single
--no-hostfsflag was introduced but concern wasraised that we should be able to disable all, and this would lead to a
proliferation of flags. Another viewpoint is that we should have all of
the
--no-xxxxxflags.This PR proposes a middle ground. Add a
--no-mountflag that can takeone or more 'mounts' to disable, overriding the
singularity.confvalue. I feel this is more clear / friendlier than using
--mount ^hostfsnegation syntax.
Implemented through individual NoXXXX booleans on the EngineConfig so it'd
be trivial to add the
--no-xxxxCLI flags later if we change ourminds.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make testallAttn: @singularity-maintainers