Fix terminal echo problem when using PID namespace and killing shell process #1168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
By killing shell container process when requesting PID namespace, terminal doesn't echo input characters anymore
Steps to reproduce:
First terminal:
$ singularity shell -p docker://busybox
Second terminal:
$ kill -9 </bin/sh pid>
Type something on first terminal
Checkoff for all PRs:
make test
Attn: @singularityware-admin