Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal echo problem when using PID namespace and killing shell process #1168

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

cclerget
Copy link
Collaborator

Description of the Pull Request (PR):

By killing shell container process when requesting PID namespace, terminal doesn't echo input characters anymore

Steps to reproduce:
First terminal:
$ singularity shell -p docker://busybox
Second terminal:
$ kill -9 </bin/sh pid>
Type something on first terminal

Checkoff for all PRs:

  • I have read the Guidelines for Contributing, and this PR conforms to the stated requirements.
  • I have tested this PR locally with a make test
  • This PR is NOT against the project's master branch
  • I have added myself as a contributor to the contributors's file
  • This PR is ready for review and/or merge

Attn: @singularityware-admin

@vsoch
Copy link
Collaborator

vsoch commented Nov 21, 2017

hey @cclerget ping me when 2.4.1 secure bulid is ready - we should update Singularity Hub for the users when it is. Ty!

@cclerget
Copy link
Collaborator Author

Hey @vsoch, I figure out that I need to create another branch and revert merge to exclude SIF stuff that I merged few days ago. I'll let you know once done

@vsoch
Copy link
Collaborator

vsoch commented Nov 21, 2017

Awesome @cclerget! There is definitely no rush, we want to make sure that the images that are built with Singularity Hub are using the most up-to-date singularity.

@gmkurtzer gmkurtzer merged commit bd606c7 into apptainer:development Nov 22, 2017
@gmkurtzer
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants