Couple New Properties #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to directly set the fragment and vertex shaders as strings
Added fps as ShaderView property. Updated readme.
Changed fps to be used in the await call of the drawing thread rather than the function that checks if ready to draw shader.
Fixed an issue where await was being given 0 rather than expected amount. Made an fps of 0 or lower a special case. Updated readme.
Moved thread await to try and fix the continuous stuck issue
Trying a different approach where the draw call is limited directly
Localized fps limiter even further
Moved back to await method but set it to right before drawing happens
Removed semicolon and encapsulated line
Quick sanity check
Fixed a stupid mistake where setting fps would set render mode instead
Reverted to original method
Added debug message to check under the hood
Switched to previously tried approach
Changed start value of prevDrawTime
Changed scope of mPrevDrawTime. Removed debug message.
Attempt at making timestep more accurate
More localized again
Unlocalized fps. Added more debug messages.
Opted for microseconds for more accuracy. Added and removed some debug messages.
Removed some debug messages. Localized again.
Added more debug messages
Unlocalized again but included more into the if statement. Removed a debug message.
Removed debug messages. Changed fps to framerate in ShaderView. Updated readme.
Added a comment to framerate in ShaderView. Made a small change to the readme.
Trying await method again. Made tiny change to readme.
Changed await to sleep.
Added special case fps. Made small change in readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I really like the work you did here, thanks for sharing it. I needed some extra parameters for my project so I thought I'd share what I've added.
If you want me to make any modifications, let me know.