Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing branch to latest code, added default parameters to navigateTo call #5529

Conversation

ayushpahwa
Copy link
Contributor

Description

  • Synced code to the latest release code.
  • When the drop-down for actions changes to navigateTo, default values for query params and navigation target are being passed.

Fixes #5140

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Tooluloope and others added 30 commits May 6, 2021 08:18
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
-- Remove JS convertible
-- Set isBindProperty and isTriggerProperty to false
-- PositionedContainer : Add padding-bottom: 42px in case of Table widget
-- Remove extra space when the header options is all hidden
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
…fernece equality

- Moemoize getThemeDetails
somangshu and others added 29 commits June 28, 2021 13:19
…ppsmithorg#5314)

* -Add the newly added user to existing comment threads

* -update PR as per review comment

* -updated the PR as per review
… deployed (appsmithorg#5439)

This fixes the difference in the height of a button widget between edit mode and deploy mode.
* removed Reload action

* count assertion removed
…psmithorg#5446)

* Raw is now a command option instead of Form vs Raw

* Added database migration for migration raw input type to be of raw command type

* Fixed test case failure

* Minor cleanup
Updated a few words about access control and sign in.
*Total -- 1,409.96kb -> 1,370.42kb (2.8%)

/static/animations/invite.gif -- 778.42kb -> 751.72kb (3.43%)
/static/animations/login-google.gif -- 625.10kb -> 612.35kb (2.04%)
/app/client/src/assets/icons/comments/chat.svg -- 0.44kb -> 0.43kb (1.79%)
/app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.58kb -> 0.57kb (1.69%)
/app/client/src/assets/icons/comments/notifications-empty-state.svg -- 4.78kb -> 4.71kb (1.39%)
/app/client/src/assets/icons/widget/embed.svg -- 0.64kb -> 0.64kb (0.46%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
…ination in table widget (appsmithorg#4863)" (appsmithorg#5469)

This reverts commit related to appsmithorg#2230 & appsmithorg#1578. We will revisit this problem again and implement the solution based on the discussion in the thread.
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.23.0...v1.24.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added delay after typing

* updated method

* updated type in test

* updated common method

* Added wait between CreationOfUniqueAPIcheck()

Added delay between CreationOfUniqueAPIcheck() to prevent the stale exception.

* Updated API name

* Upated spec to handle retry

Co-authored-by: arslanhaiderbuttar <arslan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
appsmithorg#4427)

* fix for comma separated splitting of image url in table col of type image
* Added attribute to image widget to change cover properties
…g#5421)

* Added an API to get list of mock datsets
Removed the flow of

* Removed the auto populate of mock datasets flow when the user sign up first time

* Fixed indentation issues

* Instead of sending empty datasource, change template value to empty

* Add only the configs to response instead of entire mongo doc

* Add API to create mock data set
Syncing branch to latest release
@ayushpahwa ayushpahwa merged commit 4a18db6 into appsmithorg:bug/navigate-to-issue-3125 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.