Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor collab fixes #5271

Merged
merged 8 commits into from
Jun 24, 2021
Merged

Minor collab fixes #5271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
62690b6
WIP set unread comments threads indicator
rishabhsaxena Jun 20, 2021
d1a5249
Comment button discovery tooltip
rishabhsaxena Jun 20, 2021
c642f02
Add appsmith to suggestions list
rishabhsaxena Jun 20, 2021
b2100cb
Show open thread pin as orange
rishabhsaxena Jun 20, 2021
7aba024
Update comment mode icon
rishabhsaxena Jun 20, 2021
a49c94e
Merge branch 'release' into minor-collab-updates
rishabhsaxena Jun 23, 2021
5536362
Revert "Comment button discovery tooltip"
rishabhsaxena Jun 23, 2021
22d3af6
Merge branch 'minor-collab-updates' of https://github.com/appsmithorg…
rishabhsaxena Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'release' into minor-collab-updates
  • Loading branch information
@rishabhsaxena
rishabhsaxena authored Jun 23, 2021
commit a49c94ef8d4f8c2534dd28a9a1aa9026d9ae8df9
7 changes: 7 additions & 0 deletions app/client/src/constants/ReduxActionConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ export const ReduxActionTypes: { [key: string]: string } = {
"FETCH_UNREAD_COMMENT_THREADS_COUNT_REQUEST",
FETCH_UNREAD_COMMENT_THREADS_COUNT_SUCCESS:
"FETCH_UNREAD_COMMENT_THREADS_COUNT_SUCCESS",
MARK_NOTIFICATION_AS_READ_REQUEST: "MARK_NOTIFICATION_AS_READ_REQUEST",
MARK_NOTIFICATION_AS_READ_SUCCESS: "MARK_NOTIFICATION_AS_READ_SUCCESS",
FETCH_UNREAD_NOTIFICATIONS_COUNT_REQUEST:
"FETCH_UNREAD_NOTIFICATIONS_COUNT_REQUEST",
FETCH_UNREAD_NOTIFICATIONS_COUNT_SUCCESS:
"FETCH_UNREAD_NOTIFICATIONS_COUNT_SUCCESS",
RESET_NOTIFICATIONS: "RESET_NOTIFICATIONS",
MARK_ALL_NOTIFICATIONS_AS_READ_REQUEST:
"MARK_ALL_NOTIFICATIONS_AS_READ_REQUEST",
MARK_ALL_NOTIFICATIONS_AS_READ_SUCCESS:
Expand Down
2 changes: 0 additions & 2 deletions app/client/src/sagas/CommentSagas/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ function* fetchApplicationComments() {
if (isValidResponse) {
yield put(fetchApplicationCommentsSuccess(response.data));
yield put(fetchUnreadCommentThreadsCountRequest());
} else {
// todo invalid response
}
} catch (error) {
yield put({
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.