Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update format of evaluated value shown in the debugger #4804

Closed
wants to merge 7 commits into from
Closed

Update format of evaluated value shown in the debugger #4804

wants to merge 7 commits into from

Conversation

akash-codemonk
Copy link
Contributor

@akash-codemonk akash-codemonk commented May 31, 2021 •
edited by github-actions bot
Loading

Description

The error messages shown for widget property validation errors has been formatted.

Fixes #4761

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: feat/format-evaluate-value
Status File % Stmts % Branch % Funcs % Lines
🔴 total 51.65 (-0.02) 32.85 (-0.05) 29.58 (-0.01) 52.13 (-0.02)
🔴 app/client/src/components/editorComponents/Debugger/Errors.tsx 52.94 (-3.31) 36.36 (-30.31) 0 (0) 56.25 (-3.75)
🔴 app/client/src/components/editorComponents/Debugger/LogItem.tsx 33.33 (-5.38) 15.38 (-4.62) 0 (0) 33.33 (-5.65)
🔴 app/client/src/sagas/ActionExecutionSagas.ts 12.16 (0) 1.26 (-0.03) 7.14 (0) 13.95 (0)

rishabhsaxena
rishabhsaxena approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@rishabhsaxena rishabhsaxena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This looks a bit redundant since we already have the path in the message currently?

rishabhsaxena
rishabhsaxena reviewed Jun 16, 2021
View reviewed changes
app/client/src/components/editorComponents/Debugger/LogItem.tsx
@@ -197,6 +242,8 @@ function LogItem(props: LogItemProps) {
dispatch(toggleShowGlobalSearchModal());
}, []);

console.log(props.state, "props.state");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rm log

@akash-codemonk akash-codemonk marked this pull request as draft June 21, 2021 05:25
@akash-codemonk
Copy link
Contributor Author

Closing this as requirement was updated. Doing the necessary change in #5144

@akash-codemonk akash-codemonk deleted the feat/format-evaluate-value branch March 21, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhsaxena rishabhsaxena rishabhsaxena approved these changes

@ayushpahwa ayushpahwa Awaiting requested review from ayushpahwa ayushpahwa will be requested when the pull request is marked ready for review ayushpahwa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Update format of evaluated value in debugger
2 participants
@akash-codemonk @rishabhsaxena