move constants to Authentication.java

app/server/appsmith-interfaces/src/main/java/com/appsmith/external/constants/Authentication.java

@@ -25,6 +25,7 @@ public class Authentication {
     public static final String AUTHORIZATION_URL = "authorization_url";
     public static final String ACCESS_TOKEN_URL = "access_token_url";
     public static final String RESPONSE_TYPE = "response_type";
+    public static final String API_KEY_PARAM = "api_key";
 
     // Request parameter values
     public static final String AUTHORIZATION_CODE = "authorization_code";
@@ -35,4 +36,7 @@ public class Authentication {
 
     // Header names
     public static final String AUTHORIZATION_HEADER = "Authorization";
+
+    // Other constants
+    public static final String BEARER = "Bearer";
 }

app/server/appsmith-plugins/restApiPlugin/src/main/java/com/external/connections/ApiKeyAuthentication.java

@@ -16,13 +16,14 @@
 
 import java.net.URI;
 
+import static com.appsmith.external.constants.Authentication.API_KEY_PARAM;
+
 @Setter
 @Getter
 @Builder
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 @AllArgsConstructor(access = AccessLevel.PRIVATE)
 public class ApiKeyAuthentication extends APIConnection{
-    private final String PARAM_NAME = "api_key";
     private String key;
 
     public static Mono<ApiKeyAuthentication> create(ApiKeyAuth apiKeyAuth) {
@@ -61,7 +62,7 @@ private URI appendApiKeyParamToUrl(URI oldUrl) {
 
     private String appendApiKeyParamToQuery(String oldQuery) {
         return StringUtils.isEmpty(oldQuery) ?
-                PARAM_NAME + "=" + this.key :
-                oldQuery + "&" + PARAM_NAME + "=" + this.key;
+                API_KEY_PARAM + "=" + this.key :
+                oldQuery + "&" + API_KEY_PARAM + "=" + this.key;
     }
 }

app/server/appsmith-plugins/restApiPlugin/src/main/java/com/external/connections/BearerTokenAuthentication.java

@@ -13,14 +13,14 @@
 import reactor.core.publisher.Mono;
 
 import static com.appsmith.external.constants.Authentication.AUTHORIZATION_HEADER;
+import static com.appsmith.external.constants.Authentication.BEARER;
 
 @Setter
 @Getter
 @Builder
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 @AllArgsConstructor(access = AccessLevel.PRIVATE)
 public class BearerTokenAuthentication extends APIConnection {
-    private final String HEADER_PREFIX = "Bearer";
     private String bearerToken;
 
     public static Mono<BearerTokenAuthentication> create(BearerTokenAuth bearerTokenAuth) {
@@ -43,7 +43,6 @@ public Mono<ClientResponse> filter(ClientRequest request, ExchangeFunction next)
     }
 
     private String getHeaderValue() {
-        return HEADER_PREFIX + " " + this.bearerToken;
+        return BEARER + " " + this.bearerToken;
     }
-
 }