chore: remove klona from evalTreeWithChanges cycles becauses we aren't doing…

[vsvamsi1]

… any mutation

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14194432099
Commit: 48bda94
Cypress dashboard.
Tags: @tag.All
Spec:

---

Tue, 01 Apr 2025 12:46:06 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Streamlined internal state update processes for a more efficient handling of dynamic changes.
  • Introduced enhanced configuration options to better track and manage updates, ensuring smoother performance during ongoing operations.

[coderabbitai]

Walkthrough

This change streamlines the evaluation tree handling in the DataTreeEvaluator by eliminating redundant local copies of unEvalTree in the setupUpdateTree methods. An optional parameter isEvalTreeWithChanges is added to methods such as setupTree and setupUpdateTree to control when an internal state (this.oldUnEvalTree) should be updated. These modifications adjust the method signatures and internal control flow to more directly reference the evaluation tree state.

Changes

File	Change Summary
app/client/.../DataTreeEvaluator/index.ts	- Removed creation of a local unEvalTree copy in setupUpdateTree. - Simplified assignment in setupUpdateTreeWithDifferences to reference this.oldUnEvalTree. - Introduced the new optional parameter isEvalTreeWithChanges in methods (setupTree, setupUpdateTree) to conditionally update this.oldUnEvalTree.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Evaluator as DataTreeEvaluator
    Caller->>Evaluator: Call setupUpdateTree(unEvalTree, configTree, ..., isEvalTreeWithChanges)
    alt isEvalTreeWithChanges is false
        Evaluator->>Evaluator: Clone updatedUnEvalTree into this.oldUnEvalTree
    else isEvalTreeWithChanges is true
        Evaluator->>Evaluator: Use updatedUnEvalTree directly without updating this.oldUnEvalTree
    end
    Caller->>Evaluator: Call setupTree(updatedUnEvalTree, valuePaths, { ..., isEvalTreeWithChanges })
    alt isEvalTreeWithChanges is false
        Evaluator->>Evaluator: Update this.oldUnEvalTree from updatedUnEvalTree clone
    else isEvalTreeWithChanges is true
        Evaluator->>Evaluator: Retain current state of this.oldUnEvalTree
    end

Loading

Possibly related PRs

• chore: Add evalTreeWithDiff to evalWorkerAction #34403: Updates to DataTreeEvaluator modifying the setupUpdateTree evaluation logic, directly aligning with changes in this PR.
• chore: changed evaluateTree to use klonaJSON #37976: Alters the cloning strategy within the evaluation tree methods, showing a direct code-level connection.
• chore: remove unevalTree #34605: Involves changes in the management and removal of local unEvalTree copies, similar to the modifications here.

Suggested labels

Task, skip-changelog, ok-to-test

Suggested reviewers

• rajatagrawal
• ApekshaBhosale
• dvj1988

Poem

In the realm where trees evolve with grace,
Code paths clear, no copied trace,
A toggle here, a state refined,
Bugs and clones left far behind,
A fresh logic blooms like spring in space!
🚀🌳 Happy coding!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb5939 and 48bda94.

📒 Files selected for processing (1)

• app/client/src/workers/common/DataTreeEvaluator/index.ts (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (7)

app/client/src/workers/common/DataTreeEvaluator/index.ts (7)

636-642: Method signature update looks good.

The addition of the isEvalTreeWithChanges optional parameter provides a nice way to control when internal state is updated, which aligns with the goal of reducing unnecessary cloning operations.

---

651-654: Removed unnecessary klona operation.

Good change. The direct usage of unEvalTree instead of creating a clone is appropriate since there are no mutations happening in this context.

---

808-816: Method signature update is consistent.

Adding the optional isEvalTreeWithChanges parameter to the setupTree method signature makes it consistent with the changes in setupUpdateTree.

---

819-824: Correctly destructuring the new parameter.

Good implementation of extracting the isEvalTreeWithChanges flag from the extraParams object.

---

859-861: Conditional cloning improves performance.

Excellent optimization - only creating a clone when necessary (when isEvalTreeWithChanges is false) will reduce unnecessary memory overhead and processing time.

---

893-893: Direct assignment avoids unnecessary cloning.

This change appropriately uses direct assignment instead of cloning since we're operating on the evaluation tree with changes, which aligns with the PR objective.

---

907-910: Correctly passing the isEvalTreeWithChanges parameter.

The flag is correctly set to true here, which ensures we don't unnecessarily clone the tree when processing differences.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.