fix: Updating CSS for list item to fix UI breaking on JS module instance in EE

[ankitakinger]

Description

Updating CSS for list item to fix UI breaking on JS module instance in EE

Fixes #38557

Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12688997415
Commit: d5dd58e
Cypress dashboard.
Tags: @tag.Sanity, @tag.Datasource, @tag.IDE
Spec:
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts

List of identified flaky tests.

---

Thu, 09 Jan 2025 12:57:19 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Style
  • Adjusted list item styling by removing flex property, which may impact layout behavior

[coderabbitai]

Walkthrough

The pull request involves a modification to the StyledListItem styled component in the List.styles.tsx file. The primary change is the removal of the flex: 1; property, which previously allowed list items to expand and fill available space within a flex container. This alteration may impact the layout behavior of list items, potentially affecting how function names are displayed in JS module instances.

Changes

File	Change Summary
app/client/packages/design-system/ads/src/List/List.styles.tsx	Removed flex: 1; property from StyledListItem component

Assessment against linked issues

Objective	Addressed	Explanation
Fix breaking list item component for function names in JS module instances [#38557]	❓	Removal of flex: 1; might impact layout, but full resolution unclear without additional context

Possibly related PRs

• fix: Updating the click functionalities in list item component #38453: Modifications to ListItem component's event handling
• chore: Housekeeping of List Item and Entity Item #38524: Housekeeping changes in List component with event handling updates
• chore: Housekeeping items in List and Entity Item ADS  #38537: Additional housekeeping tasks in List component

Suggested labels

Bug, Production, IDE Product, ok-to-test

Suggested reviewers

• hetunandu

Poem

In the realm of flex and style,
A property removed with a smile,
List items dance, no longer bound,
Their layout freedom newly found,
Code's poetry, line by line! 🎨✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfd7fde and d5dd58e.

📒 Files selected for processing (1)

• app/client/packages/design-system/ads/src/List/List.styles.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• app/client/packages/design-system/ads/src/List/List.styles.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: perform-test / client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ankitakinger]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12689013814.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38558.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-38558.dp.appsmith.com