Revert "chore: Housekeeping of List Item and Entity Item"

[hetunandu]

Reverts #38524

Summary by CodeRabbit

Release Notes

• Refactor

  • Simplified event handling in various components
  • Removed unnecessary stopPropagation() calls
  • Streamlined tooltip functionality in list components

• Code Cleanup

  • Removed unused imports and props
  • Simplified class name management
  • Removed unnecessary id attributes from components

• Testing

  • Updated test cases to reflect simplified event handling

These changes focus on improving code clarity and reducing unnecessary complexity in the design system components.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces modifications to several files within the design system's list and entity explorer components. The changes primarily focus on refactoring event handling, removing unnecessary props and imports, and enhancing tooltip functionality. The modifications streamline component interactions, simplify event management, and improve the overall structure of the components.

Changes

File	Change Summary
app/client/packages/design-system/ads/src/List/List.tsx	Enhanced TextWithTooltip with new ref and useEffect for improved text overflow detection
app/client/packages/design-system/ads/src/List/List.types.tsx	Simplified onClick method signature, removed MouseEvent import
app/client/packages/design-system/ads/src/Templates/EntityExplorer/Editable/useEditableText.test.tsx	Removed stopPropagation() from keyboard event test cases
app/client/packages/design-system/ads/src/Templates/EntityExplorer/Editable/useEditableText.ts	Removed e.stopPropagation() from handleKeyUp function
app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.stories.tsx	Removed id prop from EntityItem component
app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.tsx	Removed classnames import and related class name management
app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.types.ts	Removed id property from EntityItemProps interface

Possibly related PRs

• fix:- added elipsis and tooltip to the button content in table widget component #36865: Ellipsis and tooltip functionality for button content
• feat: ADS Entity Item #38442: EntityItem component with tooltip management
• chore: Housekeeping of List Item and Entity Item #38524: Updates to list item click functionalities

Suggested Labels

Bug, IDE Product, ok-to-test

Suggested Reviewers

• ankitakinger

Poem

🧹 Refactoring dance, code so light,
Tooltips shine, events take flight!
Props removed, imports set free,
Cleaner code for you and me! 🌟
A symphony of TypeScript's might! 💻

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7fd50c5 and 948fcf2.

📒 Files selected for processing (7)

• app/client/packages/design-system/ads/src/List/List.tsx (3 hunks)
• app/client/packages/design-system/ads/src/List/List.types.tsx (2 hunks)
• app/client/packages/design-system/ads/src/Templates/EntityExplorer/Editable/useEditableText.test.tsx (2 hunks)
• app/client/packages/design-system/ads/src/Templates/EntityExplorer/Editable/useEditableText.ts (0 hunks)
• app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.stories.tsx (0 hunks)
• app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.tsx (0 hunks)
• app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.types.ts (0 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.