Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADS Entity Item #38442

Merged
merged 20 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests
  • Loading branch information
hetunandu committed Jan 2, 2025
commit 98a50b4248bf0ad319f27b5be77a69d6203bfe8f
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
import React from "react";
import { renderHook, act } from "@testing-library/react-hooks";
import { useEditableText } from "./useEditableText";
import { fireEvent, render } from "@testing-library/react";
import { Text } from "../../..";

describe("useEditableText", () => {
const mockExitEditing = jest.fn();
const mockOnNameSave = jest.fn();
const mockValidateName = jest.fn();

beforeEach(() => {
jest.clearAllMocks();
});

test("initial state", () => {
mockValidateName.mockReturnValueOnce(null);
const { result } = renderHook(() =>
useEditableText(
false,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [inputRef, editableName, validationError] = result.current;

expect(editableName).toBe("initial_name");
expect(validationError).toBeNull();
expect(inputRef.current).toBeNull();
});

test("handle name change", () => {
mockValidateName.mockReturnValueOnce(null);
const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [, , , , handleTitleChange] = result.current;

act(() => {
handleTitleChange({
target: { value: "new_name" },
} as React.ChangeEvent<HTMLInputElement>);
});

const [, editableName, validationError] = result.current;

expect(editableName).toBe("new_name");
expect(validationError).toBeNull();
});

test("handle valid name save on Enter key", () => {
mockValidateName.mockReturnValueOnce(null);

const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [, , , handleKeyUp, handleTitleChange] = result.current;

act(() => {
handleTitleChange({
target: { value: "new_name" },
} as React.ChangeEvent<HTMLInputElement>);
});

act(() => {
handleKeyUp({
key: "Enter",
} as unknown as React.KeyboardEvent<HTMLInputElement>);
});

expect(mockOnNameSave).toHaveBeenCalledWith("new_name");
expect(mockExitEditing).toHaveBeenCalled();
});

test("handle invalid name save on Enter key", () => {
mockValidateName.mockReturnValue("Invalid");

const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [, , , handleKeyUp, handleTitleChange] = result.current;

act(() => {
handleTitleChange({
target: { value: "invalid_name" },
} as React.ChangeEvent<HTMLInputElement>);
});

act(() => {
handleKeyUp({
key: "Enter",
} as unknown as React.KeyboardEvent<HTMLInputElement>);
});

expect(mockOnNameSave).not.toHaveBeenCalled();
expect(mockExitEditing).toHaveBeenCalled();
});

test("handle exit without saving on Escape key", () => {
const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [, , , handleKeyUp] = result.current;

act(() => {
handleKeyUp({ key: "Escape" } as React.KeyboardEvent<HTMLInputElement>);
});

expect(mockExitEditing).toHaveBeenCalled();
expect(mockOnNameSave).not.toHaveBeenCalled();
});

test("handle exit without saving on no change", () => {
const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [, , , handleKeyUp] = result.current;

act(() => {
handleKeyUp({ key: "Enter" } as React.KeyboardEvent<HTMLInputElement>);
});

expect(mockExitEditing).toHaveBeenCalled();
expect(mockOnNameSave).not.toHaveBeenCalled();
});

test("handle focus out event", () => {
mockValidateName.mockReturnValue(null);
const { result } = renderHook(() =>
useEditableText(
true,
"initial_name",
mockExitEditing,
mockValidateName,
mockOnNameSave,
),
);

const [inputRef, , , , handleChange] = result.current;

const inputProps = { onChange: handleChange };

const TestComponent = () => {
return (
<Text inputProps={inputProps} inputRef={inputRef} isEditable>
Text
</Text>
);
};

render(<TestComponent />);

act(() => {
handleChange({
target: { value: "new_name" },
} as React.ChangeEvent<HTMLInputElement>);
});

act(() => {
if (inputRef.current) {
fireEvent.focusOut(inputRef.current);
}
});

expect(mockOnNameSave).toHaveBeenCalledWith("new_name");
expect(mockExitEditing).toHaveBeenCalled();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ export { EmptyState } from "./EmptyState";
export { NoSearchResults } from "./NoSearchResults";
export * from "./ExplorerContainer";
export * from "./EntityItem";
export { useEditableText } from "./Editable";
Loading
Loading