Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken UI on JS module instance in the side by side view mode #37909

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Dec 3, 2024

Description

Fixing the Broken UI on JS module instance in the side by side view mode.

Fixes #37906

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12135280169
Commit: bc011f0
Cypress dashboard.
Tags: @tag.IDE
Spec:


Tue, 03 Dec 2024 08:32:26 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced flexibility of the dropdown selector in the JS Function Run component by removing the minimum width constraint.
  • Bug Fixes

    • Adjusted layout to improve the visual adaptability of the dropdown selector based on its content.

Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

Walkthrough

The changes involve a modification to the JSFunctionRun component within the JSFunctionRun.tsx file. Specifically, a CSS rule that set the minimum width of the .rc-select-selector class in the DropdownWithCTAWrapper styled component has been removed. This adjustment allows for a more flexible layout of the dropdown selector, while the overall structure and functionality of the component remain intact.

Changes

File Path Change Summary
app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/old/JSFunctionRun.tsx Removed the CSS rule that set the minimum width for the .rc-select-selector class.

Possibly related PRs

  • chore: Update JS Editor Run designs #36998: This PR modifies the JSFunctionRun component, which is directly related to the changes made in the main PR that also affects the JSFunctionRun component by altering CSS rules for dropdowns.
  • fix: Min width in certain ADS Button usage #37624: This PR removes the minimum width constraint in the Debugger trigger button, which aligns with the main PR's changes to the dropdown's minimum width, indicating a broader effort to improve component responsiveness.
  • fix: Plugin Action Editor navigation issue with git #37670: This PR addresses navigation issues in the Plugin Action Editor, which may indirectly relate to the overall UI improvements and responsiveness being targeted in the main PR's changes to dropdown components.

Suggested labels

Bug, IDE Product, IDE Pod, ok-to-test, ADS Visual Styles

Suggested reviewers

  • albinAppsmith

🎉 In the land of code where styles do roam,
A dropdown now flexes, finding its home.
With widths set free, it dances with grace,
In the JSFunctionRun, it finds its new place.
So here's to the changes, both bold and bright,
Making our UI a pure delight! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 493abee and bc011f0.

📒 Files selected for processing (1)
  • app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/old/JSFunctionRun.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/old/JSFunctionRun.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankitakinger ankitakinger added the ok-to-test Required label for CI label Dec 3, 2024
@github-actions github-actions bot added the Bug Something isn't working label Dec 3, 2024
@ankitakinger ankitakinger merged commit f746c53 into release Dec 3, 2024
46 checks passed
@ankitakinger ankitakinger deleted the fix/broken-ui-js-module branch December 3, 2024 08:40
ankitakinger added a commit that referenced this pull request Dec 3, 2024
…37909)

## Description

Fixing the Broken UI on JS module instance in the side by side view
mode.

Fixes #

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12135280169>
> Commit: bc011f0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12135280169&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Tue, 03 Dec 2024 08:32:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced flexibility of the dropdown selector in the JS Function Run
component by removing the minimum width constraint.

- **Bug Fixes**
- Adjusted layout to improve the visual adaptability of the dropdown
selector based on its content.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
btsgh added a commit that referenced this pull request Dec 3, 2024
…e-instance-fix

fix: Broken UI on JS module instance in the side by side view mode (#37909)
@github-actions github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage Release Release Blocker This issue must be resolved before the release labels Dec 5, 2024
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Dec 9, 2024
…ppsmithorg#37909)

## Description

Fixing the Broken UI on JS module instance in the side by side view
mode.

Fixes #

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12135280169>
> Commit: bc011f0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12135280169&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Tue, 03 Dec 2024 08:32:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced flexibility of the dropdown selector in the JS Function Run
component by removing the minimum width constraint.

- **Bug Fixes**
- Adjusted layout to improve the visual adaptability of the dropdown
selector based on its content.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Release Blocker This issue must be resolved before the release Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The JS module instance function dropdown seems to be disturbed in the Split Pane UI .
3 participants