chore: TX management with entity manager #37646

abhvsn · 2024-11-22T07:55:21Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

/test All

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12505177742
Commit: 95ca387
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Binding/Api_withPageload_Input_spec.js
cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js
cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js
cypress/e2e/Regression/ServerSide/ApiTests/API_MultiPart_Spec.ts
cypress/e2e/Sanity/Datasources/DatasourceForm_spec.js

List of identified flaky tests.

Thu, 26 Dec 2024 15:59:05 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

coderabbitai · 2024-11-22T07:55:29Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

abhvsn · 2024-11-22T07:55:54Z

...ppsmith-server/src/main/java/com/appsmith/server/applications/base/ApplicationServiceCE.java

@@ -103,4 +103,6 @@ Mono<Application> findByBaseIdBranchNameAndApplicationMode(
            String defaultApplicationId, String branchName, ApplicationMode mode);

    Mono<Application> findByBranchedApplicationIdAndApplicationMode(String branchedApplicationId, ApplicationMode mode);
+
+    Mono<Application> findSaveUpdateApp(String id);


This is for testing purpose

…ty-manager

github-actions · 2024-11-27T09:15:58Z

Failed server tests

com.appsmith.server.git.CommonGitServiceCETest#checkoutRemoteBranch_CustomThemeSetToDefaultAppAndRemoteBranch_AppAndThemesCreated
com.appsmith.server.git.CommonGitServiceCETest#checkoutRemoteBranch_notPresentInLocal_newApplicationCreated
com.appsmith.server.git.CommonGitServiceCETest#connectArtifactToGit_WithEmptyPublishedPages_CloneSuccess
com.appsmith.server.git.CommonGitServiceCETest#createBranch_BranchDeleteLogo_SrcLogoRemainsUnchanged
com.appsmith.server.git.CommonGitServiceCETest#createBranch_BranchHasCustomApplicationSettings_SrcBranchRemainsUnchanged
com.appsmith.server.git.CommonGitServiceCETest#createBranch_BranchSetPageIcon_SrcBranchPageIconRemainsNull
com.appsmith.server.git.CommonGitServiceCETest#createBranch_BranchUploadLogo_SrcBranchRemainsUnchanged
com.appsmith.server.git.CommonGitServiceCETest#createBranch_SrcHasCustomTheme_newApplicationCreatedWithThemesCopied
com.appsmith.server.git.CommonGitServiceCETest#createBranch_cancelledMidway_newApplicationCreated
com.appsmith.server.git.CommonGitServiceCETest#createBranch_validCreateBranchRequest_newApplicationCreated
com.appsmith.server.git.CommonGitServiceCETest#deleteBranch_defaultBranchUpdated_Success
com.appsmith.server.git.CommonGitServiceCETest#isBranchMergeable_conflictingChanges_canNotBeMerged
com.appsmith.server.git.CommonGitServiceCETest#isBranchMergeable_nonConflictingChanges_canBeMerged
com.appsmith.server.git.CommonGitServiceCETest#isBranchMergeable_remoteAhead_remoteAheadErrorMessage
com.appsmith.server.git.CommonGitServiceCETest#listBranchForArtifact_defaultBranchChangesInRemoteDoesNotExistsInDB_Success
com.appsmith.server.git.CommonGitServiceCETest#listBranchForArtifact_defaultBranchChangesInRemoteExistsInDB_Success

…ty-manager

github-actions · 2024-12-05T03:51:56Z

Failed server tests

com.appsmith.server.git.ServerSchemaMigrationEnforcerTest#saveGitRepo_ImportAndThenExport_diffOccurs
com.appsmith.server.services.ActionCollectionServiceTest#testUpdateUnpublishedActionCollection_createNewActionsWithSameNameAsExisting_returnsDuplicateActionNameError
com.appsmith.server.services.LayoutActionServiceTest#updateLayout_WhenPageLoadActionSetBothWaysExplicitlyAndImplicitlyViaWidget_ActionsSaved

…ty-manager

github-actions · 2024-12-11T13:19:35Z

Failed server tests

com.appsmith.server.services.UserWorkspaceServiceUnitTest#getUserWorkspacesByRecentlyUsedOrder_withRecentlyUsedWorkspaces_allEntriesWithSameOrderAreReturned
com.appsmith.server.services.ce.ApplicationServiceCETest#publishApplication_withPageIconSet_success

…e.save method

…service

…is and should be treated as warning)

…ory class

github-actions · 2024-12-11T19:45:25Z

Failed server tests

com.appsmith.server.repositories.ce.CustomNewActionRepositoryCEImplTest#bulkInsert_WhenDuplicateId_ExceptionThrown

…ulkInsert

abhvsn · 2024-12-11T20:15:18Z

/build-deploy-preview skip-tests=true

github-actions · 2024-12-11T20:15:42Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12284174021.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 37646.
recreate: .

github-actions · 2024-12-11T20:24:48Z

Deploy-Preview-URL: https://ce-37646.dp.appsmith.com

github-actions · 2024-12-19T16:38:19Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

…ty-manager

abhvsn added 9 commits November 20, 2024 16:39

chore: Working state

a987818

wip

ced4062

wip

2092571

wip

d1f4a42

wip

fb7f072

wip

21e2297

wip

661442e

wip

bbe83e4

chore: Build is passing now

76059a8

abhvsn commented Nov 22, 2024

View reviewed changes

abhvsn added 4 commits November 22, 2024 13:42

Merge branch 'pg' of github.com:appsmithorg/appsmith into poc/tx-enti…

71da8a2

…ty-manager

chore: Add CRUDRepository extension

1b8b3a0

now we are talking 🎉, we have a testcase passing with custom transaction

8ae5fa1

Multi repo test

ddeb58e

appsmithorg deleted a comment from github-actions bot Nov 27, 2024

chore: Fix tests with save op

b41542c

appsmithorg deleted a comment from github-actions bot Nov 27, 2024

abhvsn added 2 commits November 27, 2024 13:36

chore: Fix delete repo method

66de4c5

chore: Merge pg and add entity manager in getDefaultTenant

1d49fab

chore: Handle cacheable repo methods

24495f7

appsmithorg deleted a comment from github-actions bot Nov 27, 2024

abhvsn added 2 commits November 28, 2024 01:41

Merge branch 'pg' of github.com:appsmithorg/appsmith into poc/tx-enti…

aeaefdc

…ty-manager

chore: Close entity manager in custom transaction

2cc9f0a

appsmithorg deleted a comment from github-actions bot Nov 28, 2024

abhvsn added 5 commits December 3, 2024 23:41

fix: Add seperate scheduler for DB ops

9a10e35

feat: Effectively utilise the db and transaction threads

a0b18c0

fix: Tests

ba9d0dd

Merge branch 'pg' of github.com:appsmithorg/appsmith into poc/tx-enti…

0e53fb0

…ty-manager

chore: Persist entities for bulk ops

daa3fa4

abhvsn added 6 commits December 6, 2024 11:45

fix: Out of memory exception, add custom transactions on base cake class

e03c819

Merge branch 'pg' of github.com:appsmithorg/appsmith into poc/tx-enti…

4958f96

…ty-manager

chore: Merge pg and resolve conflicts

7d37c51

chore: Fix findAllById method

db7d709

fix: CommonGitTest for id modification error

4073ddc

fix: LayoutServiceTest to use single transaction

56add0e

abhvsn added 6 commits December 11, 2024 23:03

fix: Forking test by fixing constraint violation exception in baseCak…

3420456

…e.save method

fix: bulkUpdate and bulkInsert by using saveAll

67c74c8

fix: usage pulse test by adding transactional for updateById in user …

e7ad71e

…service

fix: data integrity exceptions by relying on message

99e6f8f

fix: Serialise DB calls for user workspace service test (look into th…

59c5c8e

…is and should be treated as warning)

fix: Appsmith repository test by moving JPA methods to custom reposit…

d017d0a

…ory class

fix: NewActionRepositoryTest as we are using the saveAll instead of b…

3acbe10

…ulkInsert

appsmithorg deleted a comment from github-actions bot Dec 11, 2024

github-actions bot added the Stale label Dec 19, 2024

Merge branch 'pg' of github.com:appsmithorg/appsmith into poc/tx-enti…

95ca387

…ty-manager

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: TX management with entity manager #37646

chore: TX management with entity manager #37646

abhvsn commented Nov 22, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Nov 22, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

abhvsn Nov 22, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

abhvsn commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 19, 2024

chore: TX management with entity manager #37646

Are you sure you want to change the base?

chore: TX management with entity manager #37646

Conversation

abhvsn commented Nov 22, 2024 • edited by github-actions bot Loading

Description

🔍 Cypress test results

Communication

coderabbitai bot commented Nov 22, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

abhvsn Nov 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024

Failed server tests

github-actions bot commented Dec 5, 2024

Failed server tests

github-actions bot commented Dec 11, 2024

Failed server tests

github-actions bot commented Dec 11, 2024

Failed server tests

abhvsn commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 19, 2024

abhvsn commented Nov 22, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Nov 22, 2024 •

edited

Loading