fix: show bindings menu does not appear in split mode #36378

a6hishekpandey · 2024-09-17T13:39:13Z

Description

Issue: Show bindings menu does not appear in split mode.

This PR addresses issue #35775 by updating left style property appropriately based on the editor view mode (split screen/full screen).

Fixes #35775

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Enhanced the responsiveness of the EntityProperties component by adapting its layout based on the IDE view mode, improving user experience across different interface configurations.

…does-not-appear-in-split-mode

coderabbitai · 2024-09-17T13:39:22Z

Walkthrough

The changes in this pull request enhance the EntityProperties.tsx file by introducing a dependency on the IDE view mode. This allows for conditional styling of a UI element based on whether the IDE is in split-screen mode or not. The left style property is adjusted accordingly, improving the layout behavior of the EntityProperties component to better accommodate different user interface configurations.

Changes

File	Change Summary
`app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx`	Introduced `ideViewMode` dependency to conditionally set the `left` style property based on the current IDE view mode.

Assessment against linked issues

Objective	Addressed	Explanation
Show bindings menu does not appear in split mode (#35775)	✅

Possibly related PRs

fix: show bindings sub-menu position has been displaced #36340: This PR modifies the same EntityProperties.tsx file and involves changes to the left style property, which is directly related to the layout behavior of the UI component.

Suggested labels

Bug, IDE Product, Needs Triaging, ok-to-test

Suggested reviewers

hetunandu
a6hishekpandey

Poem

In the realm of code where changes flow,
A split-screen fix begins to glow.
With styles that shift and elements align,
The UI dances, oh so fine!
A binding menu now takes its place,
Enhancing the user's interface space! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…does-not-appear-in-split-mode

…ear-in-split-mode

alex-golovanov · 2024-09-20T08:03:54Z

/build-deploy-preview skip-tests=true

github-actions · 2024-09-20T08:04:17Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10955544054.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36378.
recreate: .

github-actions · 2024-09-20T08:18:19Z

Deploy-Preview-URL: https://ce-36378.dp.appsmith.com

alex-golovanov · 2024-09-20T11:23:50Z

app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx

@@ -123,7 +127,10 @@ export function EntityProperties() {
        ref.current.style.bottom = "unset";
      }

-      ref.current.style.left = DEFAULT_EXPLORER_PANE_WIDTH + "px";
+      ref.current.style.left =


I don't think we should manipulate the DOM directly in this scenario and normally I would request for a refactor of such. However, given that this is working fix from an external contributor and it would be too much to ask to fix our mess, I'll approve this PR and create a separate issue to refactor this component later.

@alex-golovanov okay, thankyou.

alex-golovanov · 2024-09-20T12:04:12Z

Waiting for tests to complete in the shadow PR

) ## Description Issue: Show bindings menu does not appear in split mode. This PR addresses issue appsmithorg#35775 by updating `left` style property appropriately based on the editor view mode (split screen/full screen). Fixes appsmithorg#35775 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Enhanced the responsiveness of the EntityProperties component by adapting its layout based on the IDE view mode, improving user experience across different interface configurations.

a6hishekpandey and others added 2 commits September 17, 2024 19:03

Fix show binding menu does not appear in split view

17bc64f

Merge branch 'appsmithorg:release' into fix/35775-show-bindings-menu-…

39108a7

…does-not-appear-in-split-mode

a6hishekpandey changed the title ~~fix: show bindings menu does not appear in split mode #35775~~ fix: show bindings menu does not appear in split mode Sep 17, 2024

a6hishekpandey and others added 3 commits September 18, 2024 12:53

Merge branch 'appsmithorg:release' into fix/35775-show-bindings-menu-…

aed9950

…does-not-appear-in-split-mode

Address prettier's style issues

22689dd

Merge branch 'release' into fix/35775-show-bindings-menu-does-not-app…

093ffed

…ear-in-split-mode

a6hishekpandey mentioned this pull request Sep 19, 2024

fix: duplicate page name error does not disappear on navigating to other pages #36320

Merged

2 tasks

alex-golovanov requested review from alex-golovanov and rishabhrathod01 and removed request for alex-golovanov and rishabhrathod01 September 19, 2024 12:54

alex-golovanov reviewed Sep 20, 2024

View reviewed changes

alex-golovanov self-requested a review September 20, 2024 12:53

alex-golovanov approved these changes Sep 20, 2024

View reviewed changes

KelvinOm merged commit 54a0f2b into appsmithorg:release Sep 20, 2024
16 of 17 checks passed

a6hishekpandey deleted the fix/35775-show-bindings-menu-does-not-appear-in-split-mode branch September 20, 2024 17:09

coderabbitai bot mentioned this pull request Nov 25, 2024

chore: Removing unused styles, extra space in entity item and passing button condition prop #37674

Merged

2 tasks

coderabbitai bot mentioned this pull request Dec 20, 2024

fix: property pane in preview mode #38274

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show bindings menu does not appear in split mode #36378

fix: show bindings menu does not appear in split mode #36378

a6hishekpandey commented Sep 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

alex-golovanov commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

alex-golovanov Sep 20, 2024

a6hishekpandey Sep 20, 2024

alex-golovanov commented Sep 20, 2024

fix: show bindings menu does not appear in split mode #36378

fix: show bindings menu does not appear in split mode #36378

Conversation

a6hishekpandey commented Sep 17, 2024 • edited by coderabbitai bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Sep 17, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

alex-golovanov commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

alex-golovanov Sep 20, 2024

Choose a reason for hiding this comment

a6hishekpandey Sep 20, 2024

Choose a reason for hiding this comment

alex-golovanov commented Sep 20, 2024

a6hishekpandey commented Sep 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 17, 2024 •

edited

Loading