Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Anvil only: Automatically delete redundant zones #34879

Merged
merged 6 commits into from
Jul 16, 2024
Merged

chore: Anvil only: Automatically delete redundant zones #34879

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2262349
delete redundant zones
znamenskii-ilia Jul 11, 2024
a6d2c7c
continue iterating over parents
znamenskii-ilia Jul 11, 2024
a9f47e9
add comment for isRedundantZoneWidget
znamenskii-ilia Jul 11, 2024
c250347
feat: remove redundant zone after removing widget
znamenskii-ilia Jul 12, 2024
6eb7fa1
use pure function instead of generator
znamenskii-ilia Jul 12, 2024
d2a5392
fix condition
znamenskii-ilia Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment for isRedundantZoneWidget
  • Loading branch information
@znamenskii-ilia
znamenskii-ilia committed Jul 11, 2024
commit a9f47e9e46947988b61c7113193bb2e0129300aa
1 change: 1 addition & 0 deletions app/client/src/layoutSystems/anvil/utils/layouts/update/zoneUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,5 +257,6 @@ export const isRedundantZoneWidget = (
): boolean =>
isZoneWidget(widget) &&
isEmptyWidget(widget) &&
// Check that the zone is the only child of the parent section.
widgetChildren(parentSection).length === 1 &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we checking by this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the zone is the only child in the parent. I will add a comment

!hasWidgetJsPropertiesEnabled(widget);
Loading