-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added function overloading to remove redundant db call #33060
chore: added function overloading to remove redundant db call #33060
Conversation
WalkthroughWalkthroughThe recent modifications involve enhancing the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files not reviewed due to errors (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Description
This PR overloads the function
getTenantConfiguration()
to avoid callinggetDefaultTenant()
multiple times and eventually reducing the number of database calls.Subsequent EE PR - https://github.com/appsmithorg/appsmith-ee/pull/4073
Fixes #https://github.com/appsmithorg/appsmith-ee/issues/4061
Automation
/ok-to-test tags="@tag.Settings,@tag.Perf,@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8893900698
Commit: 446e4f7
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?