Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added function overloading to remove redundant db call #33060

Merged

Conversation

NilanshBansal
Copy link
Contributor

@NilanshBansal NilanshBansal commented Apr 30, 2024

Description

This PR overloads the function getTenantConfiguration() to avoid calling getDefaultTenant() multiple times and eventually reducing the number of database calls.
Subsequent EE PR - https://github.com/appsmithorg/appsmith-ee/pull/4073

Fixes #https://github.com/appsmithorg/appsmith-ee/issues/4061

Automation

/ok-to-test tags="@tag.Settings,@tag.Perf,@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8893900698
Commit: 446e4f7
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented Apr 30, 2024

Walkthrough

Walkthrough

The recent modifications involve enhancing the TenantServiceCE and its implementation TenantServiceCEImpl to handle tenant configurations asynchronously using reactive programming. Both the interface and its implementation now utilize Mono<Tenant> to process tenant data, ensuring that methods are non-blocking and more efficient in handling potentially time-consuming I/O operations.

Changes

File Path Change Summary
.../services/ce/TenantServiceCE.java Added Mono<Tenant> getTenantConfiguration(Mono<Tenant> dbTenantMono); to the interface.
.../services/ce/TenantServiceCEImpl.java Updated getTenantConfiguration to accept and return Mono<Tenant>. Modified getClientPertinentTenant to return Mono<Tenant>.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 32cbf2d and 446e4f7.
Files selected for processing (2)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/TenantServiceCE.java (1 hunks)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/TenantServiceCEImpl.java (4 hunks)
Files not reviewed due to errors (2)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/TenantServiceCE.java (no review received)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/TenantServiceCEImpl.java (no review received)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 30, 2024
@NilanshBansal NilanshBansal self-assigned this Apr 30, 2024
@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label Apr 30, 2024
@NilanshBansal NilanshBansal merged commit c0aaab8 into release May 1, 2024
52 of 53 checks passed
@NilanshBansal NilanshBansal deleted the chore/issue-ee-4061/remove-redundant-db-call branch May 1, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants