fix: Closing modal in Split view, exits code mode

[hetunandu]

Description

Avoids widget selection on modal close when widget selection is blocked.

Fixes #32118

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Important

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8453269683
Commit: a1c3fdbc4e21cdbb2627d4b1fe71bb427bfef291
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Summary by CodeRabbit

• Refactor
  • Enhanced the modal overlay functionality to improve user interaction.
  • Optimized modal handling to ensure smoother user experience.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve refining modal behavior in a web application. Specifically, unnecessary widget selection actions are removed to streamline modal interactions. Additionally, a new check is introduced to prevent modal actions when widget selection is blocked, enhancing modal management and user experience.

Changes

File Path	Change Summary
.../modalOverlay/ModalOverlayLayer.tsx	Removed unnecessary widget selection actions
.../sagas/ModalSagas.ts	Added check for widget selection block before modal actions

Assessment against linked issues

Objective	Addressed	Explanation
Prevent modal from switching to UI mode when closed in Code mode (#32118)	✅
Prevent modal actions when widget selection is blocked, enhancing modal management (#30653)	✅
Ensure modals and widgets behave correctly on mobile and comply with accessibility standards (#30788)	❌	Changes do not directly address mobile device or accessibility compliance concerns.
Address performance issues for modals on low-end devices (#30788)	❌	Performance improvements for low-end devices are not covered by these changes.

Related issues

• Issue [Bug]: WDS Modal critical issues #30653: The modifications to modal behavior and the introduction of a check for widget selection block could potentially address the objective of improving modal widget interaction consistency.
• Issue [Feature]-[720]:Pressing Escape to close a modal should count as a quick dismissal. #21552: Although not directly related, the changes in modal behavior could indirectly influence the user experience regarding modal dismissal, which is a concern in this issue. However, specific objectives such as binding the Escape key are not addressed.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.