-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Cypress | Replace static waits from Helpers + Flaky fixes #29856
Conversation
WalkthroughWalkthroughThe updates across various Cypress support and test files reflect a concerted effort to enhance test reliability and maintainability. Key changes include the removal of direct Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7327803546. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7328156168. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7327803546.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7328156168.
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7328548373. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7328156168.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7328548373.
|
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7329860759. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7329957638. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7329860759.
To know the list of identified flaky tests - Refer here |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7329957638.
|
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7404420544. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7404731011. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7404420544.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7404731011.
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7407669710. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7407669710.
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7408252213. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7408252213.
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7408947705. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7408947705.
To know the list of identified flaky tests - Refer here |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7409702853. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7408947705. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7409702853. |
Description
- apiPage.CreateApi(), apiPage.CreateAndFillGraphqlApi()
- app/client/cypress/support/Pages/AppSettings/ThemeSettings.ts
- cy.CreateNewAppInNewWorkspace() - replaced static wait with dynamic check
- dataSources.NavigateToDSCreateNew() - removed wait, updated logic
- agHelper.VerifyEvaluatedValue()
- /Git/GitSync/GitSyncedApps_spec.js (fixed testcase # 2 - 4th onwards is failing due to childbranch/master change - to be checked further)
- /Git/GitDiscardChange/DiscardChanges_spec.js (EditorNavigation.NavigateToDatasource(), Sidebar.navigate())
- /BugTests/ApiBugs_Spec.ts (3rd case)
- /Dropdown/Dropdown_onOptionChange_spec.js (3rd case)
- /ServerSide/ApiTests/API_Search_spec.js (3rd case)
Type of change
Testing
How Has This Been Tested?
Checklist:
QA activity:
Test Plan Approved
label after Cypress tests were reviewedSummary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Refactor
Chores
Tests