test: Cypress | Replace static with Dynamic waits - Part II #29557

Aishwarya-U-R · 2023-12-12T18:52:21Z

Description

This PR removes hard wait from - cypress/e2e/Regression/Apps/ folder specs & fix as needed:
- /Apps/CommunityIssues_Spec.ts
- /Apps/[EchoApiCMS_spec.js
- /Apps/ImportExportForkApplication_spec.js
- /Apps/MongoDBShoppingCart_spec.ts
- /Apps/PgAdmin_spec.js
- /Apps/PromisesApp_spec.js
This PR also removes Users mock ds dependency from below specs (using TED instead)
- ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js
- ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
Fixes Sanity/Datasources/MockDBs_Spec.ts - for record count validation

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Cypress CI runs

Checklist:

QA activity:

Added Test Plan Approved label after Cypress tests were reviewed

Summary by CodeRabbit

Tests
- Enhanced test reliability by removing hardcoded delays and utilizing dynamic waits.
- Improved test maintainability by centralizing element interactions through a custom helper.
- Streamlined test setup for database interactions, removing environment-specific conditions.
- Updated test file paths to reflect the new structure and focus areas.

coderabbitai · 2023-12-12T18:52:47Z

Walkthrough

The changes across various Cypress end-to-end test files reflect a shift towards more reliable and efficient test execution. Explicit sleep commands have been removed in favor of better asynchronous handling, and direct calls to Cypress commands have been replaced with custom helper methods. Additionally, there's a restructuring of data source creation and query execution logic, particularly for Postgres databases, and updates to file paths for test specs.

Changes

Files	Change Summary
`.../MongoDBShoppingCart_spec.ts`	Removed explicit sleep commands for better async handling.
`.../PgAdmin_spec.js`, `.../PromisesApp_spec.js`	Replaced direct `cy.xpath` calls with custom `agHelper` methods; replaced explicit waits with assertions for element presence.
`.../ListV2_PageNo_PageSize_spec.js`, `.../Listv2_BasicServerSideData_spec.js`	Restructured data source creation and query execution logic for Postgres; removed conditional blocks based on environment variables.
`.../MockDBs_Spec.ts`	Updated file paths for test specs and included new paths for ListV2 and PromisesApp tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can reply to a review comment made by CodeRabbit.
You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Aishwarya-U-R · 2023-12-12T18:56:59Z

/ci-test-limit

github-actions · 2023-12-12T18:57:31Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186022282.
Workflow: ci-test-limited.
PR: 29557.

app/client/cypress/e2e/Regression/Apps/EchoApiCMS_spec.js

github-actions · 2023-12-12T19:25:13Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7186022282.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/Apps/ImportExportForkApplication_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2023-12-12T19:33:56Z

/ci-test-limit

github-actions · 2023-12-12T19:34:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186406622.
Workflow: ci-test-limited.
PR: 29557.

Aishwarya-U-R · 2023-12-12T19:45:15Z

/ci-test-limit

github-actions · 2023-12-12T19:45:45Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186512678.
Workflow: ci-test-limited.
PR: 29557.

github-actions · 2023-12-12T20:02:00Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7186406622.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2023-12-12T20:03:02Z

/ci-test-limit

github-actions · 2023-12-12T20:03:33Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186678241.
Workflow: ci-test-limited.
PR: 29557.

github-actions · 2023-12-12T20:11:54Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7186512678.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2023-12-12T20:13:15Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186768697.
Workflow: ci-test-limited.
PR: 29557.

app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

app/client/cypress/e2e/Regression/ClientSide/Templates/ForkTemplateToGitConnectedApp.js

Aishwarya-U-R · 2023-12-12T20:16:54Z

/ci-test-limit

github-actions · 2023-12-12T20:17:23Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186819081.
Workflow: ci-test-limited.
PR: 29557.

Aishwarya-U-R · 2023-12-12T20:27:07Z

/ci-test-limit

github-actions · 2023-12-12T20:27:49Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7186918274.
Workflow: ci-test-limited.
PR: 29557.

github-actions · 2023-12-12T20:34:06Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7186678241.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-13T10:15:54Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7193093670.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2023-12-13T10:22:31Z

/ci-test-limit

github-actions · 2023-12-13T10:23:03Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7193831006.
Workflow: ci-test-limited.
PR: 29557.

Aishwarya-U-R · 2023-12-13T10:27:58Z

/ci-test-limit

github-actions · 2023-12-13T10:28:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7193897067.
Workflow: ci-test-limited.
PR: 29557.

github-actions · 2023-12-13T10:49:11Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7193831006.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2023-12-13T10:54:51Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7193897067.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2023-12-13T10:56:30Z

/ci-test-limit

github-actions · 2023-12-13T10:57:06Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7194209121.
Workflow: ci-test-limited.
PR: 29557.

github-actions · 2023-12-13T11:18:05Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7194209121.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Aishwarya-U-R · 2023-12-13T11:21:10Z

/ci-test-limit

github-actions · 2023-12-13T11:21:46Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7194488281.
Workflow: ci-test-limited.
PR: 29557.

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js

github-actions · 2023-12-13T11:41:01Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7194488281.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

sarojsarab

LGTM

mohanarpit · 2023-12-14T05:19:16Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js

-      _.dataSources.EnterQuery("SELECT * FROM users LIMIT 20;");
+  it("6. no of items rendered should be equal to page size", () => {
+    _.dataSources.CreateDataSource("Postgres");
+    cy.wait(1000);


@Aishwarya-U-R @sarojsarab Any reason we left the static wait in this test case even though we refactored it to remove external dependencies?

This spec was only targeted for removing 'Users' table dependency in this PR. Static wait removal will be done when the spec is picked for wait removal.

Its also mentioned in PR desc.

I did read the PR description, but I didn't completely understand why we didn't just remove the "static wait" when we were already editing the test case. This way, we wouldn't have to re-visit this particular spec, right? Was there a lot of added complexity in removing the wait here?

Ok, will do it from next PR.

Aishwarya-U-R added 2 commits December 13, 2023 00:19

CommunityIssues_Spec.ts removed wait

93e9e9a

run only

6e8cc7c

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Tests Test issues labels Dec 12, 2023

Aishwarya-U-R added 2 commits December 13, 2023 00:24

EchoApiCMS_spec remove wait

4a03257

ImportExportForkApplication_spec remove wait

8140e1f

coderabbitai bot reviewed Dec 12, 2023

View reviewed changes

app/client/cypress/e2e/Regression/Apps/EchoApiCMS_spec.js Outdated Show resolved Hide resolved

Apps/ImportExportForkApplication_spec.js fix

22224ba

run all

fa50741

Aishwarya-U-R requested a review from ankitakinger as a code owner December 12, 2023 20:12

coderabbitai bot reviewed Dec 12, 2023

View reviewed changes

remove wait from others

ccb6e3c

CommunityIssues_Spec clean up

a79e978

Aishwarya-U-R added 2 commits December 13, 2023 15:55

ImportExportForkApplication_spec clean up

752b6e4

removing skips

4484556

cleanup

ab477f7

Aishwarya-U-R added 2 commits December 13, 2023 16:30

cleanup

94cea34

cleanup

9b974bf

cleanup

1afa79a

coderabbitai bot reviewed Dec 13, 2023

View reviewed changes

fix

32025f7

revert

11a69b4

Aishwarya-U-R requested a review from sarojsarab December 13, 2023 12:32

Aishwarya-U-R added 2 commits December 13, 2023 18:09

revert

bbe6299

revert duplicate check

0a773a0

sarojsarab approved these changes Dec 13, 2023

View reviewed changes

Aishwarya-U-R merged commit 6343e56 into release Dec 13, 2023

Aishwarya-U-R deleted the test/dynamicwaitremove branch December 13, 2023 12:50

mohanarpit reviewed Dec 14, 2023

View reviewed changes

test: Cypress | Replace static with Dynamic waits - Part II #29557

test: Cypress | Replace static with Dynamic waits - Part II #29557

Conversation

Aishwarya-U-R commented Dec 12, 2023 • edited by coderabbitai bot Loading

Description

Type of change

Testing

How Has This Been Tested?

Checklist:

QA activity:

Summary by CodeRabbit

coderabbitai bot commented Dec 12, 2023 • edited Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

Aishwarya-U-R commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 13, 2023

Aishwarya-U-R commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

Aishwarya-U-R commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

Aishwarya-U-R commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

Aishwarya-U-R commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 13, 2023

sarojsarab left a comment

Choose a reason for hiding this comment

mohanarpit Dec 14, 2023

Choose a reason for hiding this comment

Aishwarya-U-R Dec 14, 2023

Choose a reason for hiding this comment

Aishwarya-U-R Dec 14, 2023

Choose a reason for hiding this comment

mohanarpit Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Aishwarya-U-R Dec 14, 2023

Choose a reason for hiding this comment

Aishwarya-U-R commented Dec 12, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)

mohanarpit Dec 14, 2023 •

edited

Loading