Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cypress | Replace static with Dynamic waits - Part 1 #29405

Merged
merged 40 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
f5f411c
CurrencyInputIssue_Spec removed wait
Aishwarya-U-R Dec 6, 2023
47a8863
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 7, 2023
f959ed1
GetElement improved
Aishwarya-U-R Dec 7, 2023
0471309
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 7, 2023
476f5de
run all
Aishwarya-U-R Dec 7, 2023
6c033a4
removed empty ReusableHelper
Aishwarya-U-R Dec 7, 2023
d6083ca
Table.ts methods fix
Aishwarya-U-R Dec 7, 2023
873cc7f
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 7, 2023
5e1ab82
/Widgets/Multiselect/RTL_support.ts fix
Aishwarya-U-R Dec 7, 2023
4d24400
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 7, 2023
ac71070
fix
Aishwarya-U-R Dec 7, 2023
4810bdd
eleWidth call fix
Aishwarya-U-R Dec 7, 2023
9f080bb
fix lint
Aishwarya-U-R Dec 7, 2023
185138c
skipping dscrudbindings
Aishwarya-U-R Dec 7, 2023
ae2c5de
fix lint
Aishwarya-U-R Dec 7, 2023
544d7d3
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 8, 2023
1bccc01
TableV2_Widget_API_Pagination_spec fix
Aishwarya-U-R Dec 8, 2023
57d3c28
TableV2_Widget_API_Pagination_spec remove wait
Aishwarya-U-R Dec 8, 2023
26ca80b
Debugger/Widget_property_navigation_spec.ts update
Aishwarya-U-R Dec 8, 2023
6ab788c
/Radio/Radio2_spec.ts update
Aishwarya-U-R Dec 8, 2023
d478a29
S3_1 spec fix
Aishwarya-U-R Dec 8, 2023
f4271c6
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 8, 2023
607863f
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 8, 2023
4c42c2d
Library_spec.ts reference fix
Aishwarya-U-R Dec 9, 2023
4fb8205
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 9, 2023
e21f3c8
skip ForkTemplateToGitConnectedApp.js for limited run
Aishwarya-U-R Dec 9, 2023
71cbb0e
remove only
Aishwarya-U-R Dec 9, 2023
f710a35
run only ApiTests/API_Unique_name_spec.js
Aishwarya-U-R Dec 9, 2023
282611e
removed wait /Widgets/Modal/Modal_spec.ts
Aishwarya-U-R Dec 9, 2023
c4a449a
run limit
Aishwarya-U-R Dec 9, 2023
8c092d0
run limit
Aishwarya-U-R Dec 9, 2023
a50d27d
run modal spec
Aishwarya-U-R Dec 9, 2023
d0615d5
run modal spec
Aishwarya-U-R Dec 9, 2023
f28f80c
run both
Aishwarya-U-R Dec 9, 2023
fbb0f5c
run all
Aishwarya-U-R Dec 9, 2023
bb303d4
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 9, 2023
7b07fc3
WaitUntilEleDisappear improve
Aishwarya-U-R Dec 11, 2023
a929615
Merge branch 'release' into test/dynamicwaitremove
Aishwarya-U-R Dec 11, 2023
247b49c
clean up
Aishwarya-U-R Dec 11, 2023
073b86e
remove comment
Aishwarya-U-R Dec 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed empty ReusableHelper
  • Loading branch information
Aishwarya-U-R committed Dec 7, 2023
commit 6c033a449f0c8dbeb43b13553fae29c17711362e
9 changes: 0 additions & 9 deletions app/client/cypress/support/Objects/Registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { Onboarding } from "../Pages/Onboarding";
import { AutoLayout } from "../Pages/AutoLayout";
import { DataManager } from "./DataManager";
import { AssertHelper } from "../Pages/AssertHelper";
import { ReusableHelper } from "./ReusableHelper";
import { Tabs } from "../Pages/Tabs";
import { GsheetHelper } from "../Pages/GSheetHelper";
import { CommunityTemplates } from "../Pages/CommunityTemplates";
Expand All @@ -47,14 +46,6 @@ export class ObjectsRegistry {
return ObjectsRegistry.assertHelper__;
}

private static reusableHelper__: ReusableHelper;
static get ReusableHelper(): ReusableHelper {
if (ObjectsRegistry.reusableHelper__ === undefined) {
ObjectsRegistry.reusableHelper__ = new ReusableHelper();
}
return ObjectsRegistry.reusableHelper__;
}

private static jsEditor__: JSEditor;
static get JSEditor(): JSEditor {
if (ObjectsRegistry.jsEditor__ === undefined) {
Expand Down
1 change: 0 additions & 1 deletion app/client/cypress/support/Objects/ReusableHelper.ts

This file was deleted.

3 changes: 1 addition & 2 deletions app/client/cypress/support/Pages/AggregateHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import "cypress-wait-until";
import { v4 as uuidv4 } from "uuid";
import { ObjectsRegistry } from "../Objects/Registry";
import type CodeMirror from "codemirror";
import { ReusableHelper } from "../Objects/ReusableHelper";
import type { EntityItemsType } from "./AssertHelper";
import { EntityItems } from "./AssertHelper";

Expand Down Expand Up @@ -35,7 +34,7 @@ const DEFAULT_ENTERVALUE_OPTIONS = {
inputFieldName: "",
};

export class AggregateHelper extends ReusableHelper {
export class AggregateHelper {
private locator = ObjectsRegistry.CommonLocators;
private assertHelper = ObjectsRegistry.AssertHelper;

Expand Down
4 changes: 1 addition & 3 deletions app/client/cypress/support/Pages/AssertHelper.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import "cypress-wait-until";
import { ObjectsRegistry } from "../Objects/Registry";
import { ReusableHelper } from "../Objects/ReusableHelper";

export const EntityItems = {
Page: 0,
Expand All @@ -13,7 +11,7 @@ export const EntityItems = {

export type EntityItemsType = (typeof EntityItems)[keyof typeof EntityItems];

export class AssertHelper extends ReusableHelper {
export class AssertHelper {
public _modifierKey = Cypress.platform === "darwin" ? "meta" : "ctrl";

public isMac = Cypress.platform === "darwin";
Expand Down