chore: Action execution changes for modules #29357

rishabhrathod01 · 2023-12-05T21:28:35Z

Description

CE changes for confirm before calling of query and js module

PR fixes following issue(s)

Fixes # (issue number)

Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual
JUnit
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Refactor
- Simplified the execution of JavaScript functions by consolidating parameters into a single collection object.
- Streamlined the retrieval and display of JavaScript function and collection names across the application.
New Features
- Introduced new utility functions to enhance the display of action and collection names.
Bug Fixes
- Adjusted the logic for error handling and success messaging to align with the refactored JavaScript function execution process.
Documentation
- Updated function signatures and import statements to reflect the new changes in JavaScript function execution.
Style
- Ensured consistent naming conventions for JavaScript actions and collections throughout the codebase.

rishabhrathod01 · 2023-12-05T21:29:06Z

/ok-to-test

github-actions · 2023-12-05T21:29:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7106785385.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

rishabhrathod01 · 2023-12-05T21:55:23Z

/ok-to-test

github-actions · 2023-12-05T21:55:51Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7107028099.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2023-12-05T21:55:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7106785385.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

github-actions · 2023-12-05T22:56:58Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7107028099.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-06T06:58:20Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7107028099.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts

To know the list of identified flaky tests - Refer here

rishabhrathod01 · 2023-12-06T09:23:38Z

/ok-to-test

github-actions · 2023-12-06T09:24:03Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7112572865.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

coderabbitai · 2023-12-06T09:24:49Z

Walkthrough

The changes across the codebase reflect a significant refactoring effort, primarily focusing on streamlining the handling of JavaScript collections and actions. The collectionName and collectionId parameters have been consolidated into a single collection object parameter in various functions, reducing redundancy and simplifying function signatures. Additionally, new utility functions have been introduced to aid in displaying action and collection names, and existing functions have been updated to accommodate these changes. The refactoring also includes updates to import statements and error handling logic to align with the new parameter structures.

Changes

File Path	Change Summary
`.../actions/jsPaneActions.ts` `.../reducers/entityReducers/jsActionsReducer.tsx`	Refactored functions to use `collection` object instead of separate `collectionName` and `collectionId` parameters.
`.../selectors/entitiesSelector.ts` `.../sagas/EvaluationsSaga.ts` `.../sagas/PostEvaluationSagas.ts`	Modified function signatures and imports to accommodate changes in parameter structures.
`.../utils/actionExecutionUtils.ts` `.../ce/utils/actionExecutionUtils.ts`	Added new functions for displaying action and collection names; introduced export statement for all entities from the "ce/utils/actionExecutionUtils" module.
`.../sagas/ActionExecution/PluginActionSaga.ts` `.../sagas/JSPaneSagas.ts`	Updated imports and logic to align with the refactored parameter structures and introduced utility functions.
`.../pages/Editor/JSEditor/Form.tsx`	Updated dispatch call to use `currentJSCollection` object.

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

coderabbitai · 2023-12-06T09:29:35Z

app/client/src/reducers/entityReducers/jsActionsReducer.tsx

  [ReduxActionTypes.EXECUTE_JS_FUNCTION_INIT]: (
    state: JSCollectionDataState,
    action: ReduxAction<{
-      collectionName: string;
-      collectionId: string;
+      collection: JSCollection;
      action: JSAction;
    }>,
  ): JSCollectionDataState =>
    state.map((a) => {
-      if (a.config.id === action.payload.collectionId) {
+      if (a.config.id === action.payload.collection.id) {
        const newData = { ...a.data };
        const newIsDirty = { ...a.isDirty };
        unset(newData, action.payload.action.id);


The use of unset from lodash to remove properties from newData and newIsDirty may be unnecessary since the spread operator is used to create new objects immediately after. This could be simplified by not copying these properties in the first place if they are not needed.

github-actions · 2023-12-06T12:16:16Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7112572865.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
cypress/e2e/Regression/ClientSide/Workspace/ShareAppTests_Spec.ts
cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-12-06T12:32:46Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7112572865.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts

To know the list of identified flaky tests - Refer here

rishabhrathod01 · 2023-12-06T12:41:58Z

/ok-to-test

github-actions · 2023-12-06T12:42:24Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7114659727.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2023-12-06T13:41:59Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7114659727.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

github-actions · 2023-12-06T16:23:21Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7114659727.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

chore: Action execution changes for modules

b822edc

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 5, 2023

fix import errors

dde6830

fix jsAction name in confirm modal

68071b0

rishabhrathod01 added skip-docs skip-testPlan labels Dec 6, 2023

rishabhrathod01 marked this pull request as ready for review December 6, 2023 09:24

rishabhrathod01 requested review from ApekshaBhosale and ayushpahwa as code owners December 6, 2023 09:24

coderabbitai bot reviewed Dec 6, 2023

View reviewed changes

fix pluginAction name in comfirm modal

a290847

ApekshaBhosale approved these changes Dec 6, 2023

View reviewed changes

rishabhrathod01 merged commit 6580c60 into release Dec 6, 2023
19 checks passed

rishabhrathod01 deleted the chore/ModuleconfirmBeforeExecute branch December 6, 2023 19:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Action execution changes for modules #29357

chore: Action execution changes for modules #29357

rishabhrathod01 commented Dec 5, 2023 •

edited by coderabbitai bot

Loading

rishabhrathod01 commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

rishabhrathod01 commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 6, 2023

rishabhrathod01 commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

coderabbitai bot commented Dec 6, 2023 •

edited

Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

coderabbitai bot Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

rishabhrathod01 commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

chore: Action execution changes for modules #29357

chore: Action execution changes for modules #29357

Conversation

rishabhrathod01 commented Dec 5, 2023 • edited by coderabbitai bot Loading

Description

PR fixes following issue(s)

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Summary by CodeRabbit

rishabhrathod01 commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

rishabhrathod01 commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 5, 2023

github-actions bot commented Dec 6, 2023

rishabhrathod01 commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

coderabbitai bot commented Dec 6, 2023 • edited Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

coderabbitai bot Dec 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

rishabhrathod01 commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

rishabhrathod01 commented Dec 5, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 6, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)