Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Anthropic AI Plugin #29095

Merged
merged 26 commits into from
Dec 5, 2023
Merged

feat: Anthropic AI Plugin #29095

merged 26 commits into from
Dec 5, 2023

Conversation

vivonk
Copy link
Contributor

@vivonk vivonk commented Nov 24, 2023 •
edited by coderabbitai bot
Loading

Description

Anthropic AI plugin - provides chat completion API support as a datasource plugin

PR fixes following issue(s)

Fixes #29036

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

  • Manual
  • JUnit
  • Jest
  • Cypress

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • New Features

    • Introduced a new Anthropic plugin with capabilities for testing data sources, executing actions, and validating data source configurations.
    • Added a search bar component to enhance user navigation and interaction within the application.

  • Enhancements

    • Improved form control elements, including dropdown and field array controls, for better user experience and interface consistency.
    • Optimized HTTP request handling in the OpenAI plugin for increased efficiency and performance.

  • Bug Fixes

    • Addressed issues with form control properties to ensure correct behavior and data handling.

  • Documentation

    • Updated plugin properties and test documentation to reflect new features and changes.

  • Refactor

    • Refactored various components and utilities for code clarity and maintainability.

  • Tests

    • Added comprehensive tests for the new Anthropic plugin to ensure reliability and functionality.

@github-actions github-actions bot added AI All tasks related to AI Appsmith Labs labels Nov 24, 2023
@github-actions github-actions bot added the Enhancement New feature or request label Nov 24, 2023
@vivonk
Copy link
Contributor Author

vivonk commented Nov 24, 2023

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6979992603.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

@dvj1988
Copy link
Contributor

dvj1988 commented Nov 24, 2023

/build-deploy-preview skip-tests=true recreate=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6983483751.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: true.

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

@dvj1988
Copy link
Contributor

dvj1988 commented Nov 25, 2023

/build-deploy-preview skip-tests=true recreate=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6986938923.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: true.

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

@dvj1988
Copy link
Contributor

dvj1988 commented Nov 25, 2023

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6987082337.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

@vivonk
Copy link
Contributor Author

vivonk commented Nov 28, 2023

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7022253875.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

sondermanish
sondermanish reviewed Dec 4, 2023
View reviewed changes
...ppsmith-plugins/anthropicPlugin/src/main/java/com/external/plugins/commands/ChatCommand.java Outdated
"messages are not provided in the configuration correctly");
}
for (Map<String, String> message : messagesMap) {
if (message != null && message.containsKey(ROLE) && message.containsKey(CONTENT)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more flexible in allowing the types of roles. Do we have a fix number of roles for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have two roles, HUMAN and ASSISTANT

@dvj1988 dvj1988 requested a review from sondermanish December 5, 2023 05:34
@vivonk
Copy link
Contributor Author

vivonk commented Dec 5, 2023

/ok-to-test

@vivonk
Copy link
Contributor Author

vivonk commented Dec 5, 2023

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7097552525.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7097554988.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29095.
recreate: .

sondermanish
sondermanish previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sondermanish sondermanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor Nit, else LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Deploy-Preview-URL: https://ce-29095.dp.appsmith.com

@vivonk
Copy link
Contributor Author

vivonk commented Dec 5, 2023

/ok-to-test

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7097552525.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@Aishwarya-U-R Aishwarya-U-R merged commit b03c51e into release Dec 5, 2023
8 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the feat/anthropic-ai-plugin branch December 5, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sondermanish sondermanish sondermanish approved these changes

@dvj1988 dvj1988 Awaiting requested review from dvj1988

Assignees
No one assigned
Labels
AI All tasks related to AI Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anthropic Datasource Integration
4 participants
@vivonk @dvj1988 @sondermanish @Aishwarya-U-R