Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partial export for git connected apps #29005

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

AnaghHegde
Copy link
Member

Description

Fix partial export for git connected apps.

PR fixes following issue(s)

Fixes #28997

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@AnaghHegde AnaghHegde self-assigned this Nov 21, 2023
@github-actions github-actions bot added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Nov 21, 2023
@AnaghHegde AnaghHegde changed the title fix: use the correct branch name and page id fix: partial export for git connected apps Nov 21, 2023
@github-actions github-actions bot added Partial-import-export Label for granular reusability. Release Release Blocker This issue must be resolved before the release Templates Product Issues related to Templates labels Nov 21, 2023
@AnaghHegde
Copy link
Member Author

/ok-to-test

@AnaghHegde
Copy link
Member Author

/build-deploy-preview

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6942236927.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 29005.
recreate: .

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6942232204.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29005.

Copy link

Deploy-Preview-URL: https://ce-29005.dp.appsmith.com

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6942232204.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@AnaghHegde AnaghHegde added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 21, 2023
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6942232204.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@Aishwarya-U-R Aishwarya-U-R merged commit 443883e into release Nov 21, 2023
@Aishwarya-U-R Aishwarya-U-R deleted the fix/pie-git-connected-app branch November 21, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Partial-import-export Label for granular reusability. Release Blocker This issue must be resolved before the release Release Templates Product Issues related to Templates Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while using Partial Export feature when trying to export a few parts of the app.
3 participants