Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WDS color bgNeutral, states and Subtle variant #25332

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

ichik
Copy link
Contributor

@ichik ichik commented Jul 12, 2023

Description

tl;dr States and other derivatives of bgNeutral, some fixes for bgNeutral logic itself.

Fixes #24512

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Test Plan

Initial POC refinement, no testing necessary

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@ichik ichik added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan Anvil Pod Issue related to Anvil project WDS team labels Jul 12, 2023
@ichik ichik self-assigned this Jul 12, 2023
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Enhancement New feature or request and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jul 12, 2023
@ichik ichik requested review from KelvinOm and jsartisan July 12, 2023 18:08
Copy link
Collaborator

@KelvinOm KelvinOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know if I can merge it.

@KelvinOm KelvinOm merged commit 0bc1213 into release Jul 13, 2023
@KelvinOm KelvinOm deleted the feat/wds-color-neutral-states-and-subtle branch July 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Enhancement New feature or request WDS team Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: WDS bgNeutral Active, Subtle and Hover Colors
2 participants