Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert execution instrumentation #25163

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: revert execution instrumentation #25163

merged 1 commit into from
Jul 6, 2023

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Jul 6, 2023 •
edited
Loading

Reverts #24994

@ohansFavour
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5474956586.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25163.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25163&runId=5474956586_1

@ohansFavour ohansFavour changed the title Revert "chore: Improve js execution instrumentation" fix: revert execution instrumentation Jul 6, 2023
@github-actions github-actions bot added the Bug Something isn't working label Jul 6, 2023
@ohansFavour ohansFavour requested a review from nidhi-nair July 6, 2023 11:42
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5474956586.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:


    To know the list of identified flaky tests - Refer here

    1 similar comment
    @github-actions
    Copy link

    github-actions bot commented Jul 6, 2023

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5474956586.
    Commit: ``.
    Cypress dashboard: Click here!
    The following are new failures, please fix them before merging the PR:


      To know the list of identified flaky tests - Refer here

      @nidhi-nair nidhi-nair merged commit 3df0252 into release Jul 6, 2023
      @nidhi-nair nidhi-nair deleted the revert-24994-chore/improve-js-tracking branch July 6, 2023 13:20
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @nidhi-nair nidhi-nair nidhi-nair approved these changes

      Assignees
      No one assigned
      Labels
      Bug Something isn't working
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      2 participants
      @ohansFavour @nidhi-nair