Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed ff4j configuration in favour of Flagsmith #25115

Merged
merged 1 commit into from
Jul 5, 2023
Merged

chore: Removed ff4j configuration in favour of Flagsmith #25115

merged 1 commit into from
Jul 5, 2023

Conversation

nidhi-nair
Copy link
Contributor

Description

Removes ff4j configuration so that there is only one source of truth for ff configs for ME, ie, Flagsmith.

PR fixes following issue(s)

Fixes #25074
Fixes #25075

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

  • Manual
  • Cypress

@nidhi-nair nidhi-nair self-assigned this Jul 5, 2023
@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code Query & JS Pod Issues related to the query & JS Pod Data Platform Pod Issues related to the underlying data platform Environments Product Issues related to datasource environments Frontend This label marks the issue or pull request to reference client code Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jul 5, 2023
@nidhi-nair nidhi-nair requested a review from hetunandu July 5, 2023 09:34
@nidhi-nair
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5462729949.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25115.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25115&runId=5462729949_1

@nidhi-nair nidhi-nair enabled auto-merge (squash) July 5, 2023 09:37
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5462729949.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5462729949.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@nidhi-nair nidhi-nair disabled auto-merge July 5, 2023 11:01
@nidhi-nair nidhi-nair merged commit 1ab630f into release Jul 5, 2023
@nidhi-nair nidhi-nair deleted the chore/rm-ds-env-ff4j branch July 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees

@nidhi-nair nidhi-nair

Labels
Backend This marks the issue or pull request to reference server code Data Platform Pod Issues related to the underlying data platform Environments Product Issues related to datasource environments Frontend This label marks the issue or pull request to reference client code Query & JS Pod Issues related to the query & JS Pod skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Milestone
No milestone
2 participants
@nidhi-nair @hetunandu